Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1984323005: Pass switches::kX11VisualID and use it from gl_surface_egl.cc::GetPlatformANGLEDisplay (Closed)

Created:
4 years, 7 months ago by Julien Isorce Samsung
Modified:
4 years, 7 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, darin-cc_chromium.org, jam, kalyank, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass switches::kX11VisualID and use it from gl_surface_egl.cc::GetPlatformANGLEDisplay Fixes [ERROR:gl_surface_egl.cc] eglCreateWindowSurface failed with error EGL_BAD_MATCH. The flag kEnableTransparentVisuals is not transfered from browser process to gpu process so ui::ChooseVisualForWindow can have different results. BUG=80117 R=cwallez@chromium.org, jbauman@chromium.org, kbr@chromium.org, piman@chromium.org, sadrul@chromium.org, zmo@chromium.org TEST=chrome --use-gl=angle --enable-transparent-visuals Committed: https://crrev.com/a1e42243f91912def4eb56f6f546281dda3ce838 Cr-Commit-Position: refs/heads/master@{#394683}

Patch Set 1 #

Patch Set 2 : Just rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M content/browser/browser_main_loop.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/x/x11_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/x/x11_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
Julien Isorce Samsung
PTAL. (the CL https://codereview.chromium.org/1504903003 found with git blame might help for the review)
4 years, 7 months ago (2016-05-17 22:28:34 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984323005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984323005/1
4 years, 7 months ago (2016-05-17 22:46:44 UTC) #3
Julien Isorce Samsung
On 2016/05/17 22:28:34, Julien Isorce wrote: > PTAL. (the CL https://codereview.chromium.org/1504903003 found with git blame ...
4 years, 7 months ago (2016-05-17 22:48:07 UTC) #4
piman
lgtm
4 years, 7 months ago (2016-05-17 23:37:30 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-18 00:57:12 UTC) #7
Julien Isorce Samsung
On 2016/05/18 00:57:12, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 7 months ago (2016-05-18 09:08:34 UTC) #8
Corentin Wallez
On 2016/05/18 at 09:08:34, j.isorce wrote: > On 2016/05/18 00:57:12, commit-bot: I haz the power ...
4 years, 7 months ago (2016-05-18 13:25:18 UTC) #9
sadrul
lgtm
4 years, 7 months ago (2016-05-18 22:42:13 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984323005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984323005/20001
4 years, 7 months ago (2016-05-18 22:59:09 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 00:33:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984323005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984323005/20001
4 years, 7 months ago (2016-05-19 05:07:18 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 05:11:39 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 05:14:35 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a1e42243f91912def4eb56f6f546281dda3ce838
Cr-Commit-Position: refs/heads/master@{#394683}

Powered by Google App Engine
This is Rietveld 408576698