Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1984313002: MIPS64: Add a check to addiu simulation according to the specification. (Closed)

Created:
4 years, 7 months ago by balazs.kilvady
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Add a check to addiu simulation according to the specification. BUG= Committed: https://crrev.com/c7f5419fa568991ebfc5de996a9a3b9d89a11317 Cr-Commit-Position: refs/heads/master@{#36316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/mips64/simulator-mips64.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
balazs.kilvady
4 years, 7 months ago (2016-05-17 16:35:44 UTC) #2
Ilija.Pavlovic1
lgtm
4 years, 7 months ago (2016-05-18 06:13:32 UTC) #4
akos.palfi.imgtec
lgtm
4 years, 7 months ago (2016-05-18 10:35:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984313002/1
4 years, 7 months ago (2016-05-18 10:35:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 11:05:23 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 11:05:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7f5419fa568991ebfc5de996a9a3b9d89a11317
Cr-Commit-Position: refs/heads/master@{#36316}

Powered by Google App Engine
This is Rietveld 408576698