Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1984303002: MIPS64: Fix MIPS64 related issues in GN files (Closed)

Created:
4 years, 7 months ago by gordanac
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jzern, fgalligan1, oilpan-reviews, Mads Ager (chromium), wwcv, blink-reviews, kinuko+watch, kouhei+heap_chromium.org, petar.jovanovic
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MIPS64: Fix MIPS64 related issues in GN files Sets sysroot and few missing files for MIPS64 Android. BUG=sysroot is an empty string TEST=gn gen out-gn/mips64-android --args="is_debug=false target_os=\"android\" target_cpu=\"mips64el\" chrome_public_apk_use_chromium_linker=false" ninja -C out-gn/mips64-android system_webview_apk chrome_public_apk Committed: https://crrev.com/be0e03709bbdb62d6c8585c2a191502a41ea756f Cr-Commit-Position: refs/heads/master@{#394379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M build/config/sysroot.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/toolchain/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/asm/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/libvpx/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
gordanac
Reviewers are: dpranke for files under build/ tomfinegan for third_party/libvpx/BUILD.gn haraken for third_party/WebKit/Source/platform/heap/asm/BUILD.gn Please take ...
4 years, 7 months ago (2016-05-17 16:37:14 UTC) #2
Tom Finegan
On 2016/05/17 16:37:14, gordanac wrote: > Reviewers are: > dpranke for files under build/ > ...
4 years, 7 months ago (2016-05-17 18:00:59 UTC) #3
Dirk Pranke
lgtm.
4 years, 7 months ago (2016-05-17 21:58:51 UTC) #4
haraken
WebKit LGTM
4 years, 7 months ago (2016-05-17 23:32:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984303002/1
4 years, 7 months ago (2016-05-18 09:43:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 10:48:14 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 10:49:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be0e03709bbdb62d6c8585c2a191502a41ea756f
Cr-Commit-Position: refs/heads/master@{#394379}

Powered by Google App Engine
This is Rietveld 408576698