Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1984293002: Random fixes for mash bridge classes (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, rjkroege, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Random fixes for mash bridge classes . MusLayoutManagerAdapter wasn't installed observer correctly . Updated set of activation parents. . WmGlobalMus::GetTopLevelAncestor consults set of activation parents. . WmGlobalMus deals with WindowTreeConnection being deleted while alive. . WmLookupMus installs itself as the WmLookup. . WmRootWindowController lookup key is no longer owned (it'll be owned by RootController). . Added WmRootWindowController::NotifyFullscreenStatechanged(). . Wired up WmRootWindowControllerMus observers. . Changed WmWindowMus shell ids to be stored in WmWindowMus rather than use mus::Window's local_id. This way it doesn't conflict with other code that wants to use the local id (we store the container in the local id). . Route WmWindowMus::SetBounds() to the layutmanager appropriately. . WmWindowMus::GetboundsInScreen() was including the bounds of 'this' resulting in double counting the initial offset. . WmWindowMus::Activate() moves to front. . WmWindowMus::OnWindowReordered() was notifying the wrong observers. . WmWindowMus::OnWindowSharedPropertyChanged now calls to WindowState R=jamescook@chromium.org BUG=603369 TEST=none Committed: https://crrev.com/990b86fe4ea3085e6df6dd58316a2d2c34aad241 Cr-Commit-Position: refs/heads/master@{#394170}

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 2

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -42 lines) Patch
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/mus/public/cpp/window_tree_connection_observer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mash/wm/bridge/mus_layout_manager_adapter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mash/wm/bridge/wm_globals_mus.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mash/wm/bridge/wm_globals_mus.cc View 4 chunks +24 lines, -2 lines 0 comments Download
M mash/wm/bridge/wm_lookup_mus.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M mash/wm/bridge/wm_root_window_controller_mus.h View 2 chunks +3 lines, -0 lines 0 comments Download
M mash/wm/bridge/wm_root_window_controller_mus.cc View 1 3 chunks +9 lines, -4 lines 0 comments Download
M mash/wm/bridge/wm_window_mus.h View 1 2 3 chunks +9 lines, -2 lines 0 comments Download
M mash/wm/bridge/wm_window_mus.cc View 9 chunks +31 lines, -31 lines 0 comments Download
M mash/wm/container_ids.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
sky
4 years, 7 months ago (2016-05-17 16:15:11 UTC) #1
James Cook
LGTM https://codereview.chromium.org/1984293002/diff/20001/mash/wm/bridge/wm_window_mus.h File mash/wm/bridge/wm_window_mus.h (right): https://codereview.chromium.org/1984293002/diff/20001/mash/wm/bridge/wm_window_mus.h#newcode187 mash/wm/bridge/wm_window_mus.h:187: int shell_window_id_ = -1; nit: Is this a ...
4 years, 7 months ago (2016-05-17 16:36:04 UTC) #2
sky
https://codereview.chromium.org/1984293002/diff/20001/mash/wm/bridge/wm_window_mus.h File mash/wm/bridge/wm_window_mus.h (right): https://codereview.chromium.org/1984293002/diff/20001/mash/wm/bridge/wm_window_mus.h#newcode187 mash/wm/bridge/wm_window_mus.h:187: int shell_window_id_ = -1; On 2016/05/17 16:36:04, James Cook ...
4 years, 7 months ago (2016-05-17 16:59:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984293002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984293002/40001
4 years, 7 months ago (2016-05-17 17:00:10 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-17 18:13:32 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 18:17:42 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/990b86fe4ea3085e6df6dd58316a2d2c34aad241
Cr-Commit-Position: refs/heads/master@{#394170}

Powered by Google App Engine
This is Rietveld 408576698