net/quic/quic_connection.cc - Issue 1984243002: Deprecate quic_always_has_unacked_packets_on_timeout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_connection.cc

Issue 1984243002: Deprecate quic_always_has_unacked_packets_on_timeout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@121961869

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_connection.cc

diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc

index c45fb86847542c70e251041fb5c4820a181924ec..66560c6fe416987e6d84f1a9cebb979f7c3cc12e 100644

--- a/net/quic/quic_connection.cc

+++ b/net/quic/quic_connection.cc

@@ -1841,13 +1841,7 @@ void QuicConnection::SendAck() {

}

void QuicConnection::OnRetransmissionTimeout() {

- if (FLAGS_quic_always_has_unacked_packets_on_timeout) {

- DCHECK(sent_packet_manager_.HasUnackedPackets());

- } else {

- if (!sent_packet_manager_.HasUnackedPackets()) {

- return;

- }

+ DCHECK(sent_packet_manager_.HasUnackedPackets());

if (close_connection_after_five_rtos_ &&

sent_packet_manager_.consecutive_rto_count() >= 4) {

« no previous file with comments | « no previous file | net/quic/quic_flags.h » ('j') | no next file with comments »