Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1984183002: Revert of Enable GPU Raster on OSX (Closed)

Created:
4 years, 7 months ago by Will Harris
Modified:
4 years, 7 months ago
Reviewers:
piman, vmiura, ericrk
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, ojan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable GPU Raster on OSX (patchset #4 id:140001 of https://codereview.chromium.org/1881053003/ ) Reason for revert: Causing stability issues on OS X, please put behind a fieldtrial. BUG=610544, 608566, 610971, 609612 Original issue's description: > This change enables GPU Raster on OSX. > > I've compiled a bit of benchmark data to support turning this on - > https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo7ilx9KDB_nJnwpc/edit?usp=sharing > Still filling in more data, but I'm pretty happy with the results so far. In > a number of cases we have a performance win, and in most cases we have a power win. > > Checking this in now will give us a long canary period before the next branch > point to catch any issues. > > BUG=542959 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.blink:mac_blink_rel > > Committed: https://crrev.com/8325892c2efdef8cff86ba16e7569f8b424daeda > Cr-Commit-Position: refs/heads/master@{#391655} TBR=vmiura@chromium.org,piman@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=542959, 610544, 608566, 610971, 609612 Committed: https://crrev.com/7f558620b78cc53d2a50d11b9d5bf94a229d2874 Cr-Commit-Position: refs/heads/master@{#394096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -27 lines) Patch
M content/browser/gpu/compositor_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/config/software_rendering_list_json.cc View 7 chunks +6 lines, -24 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Will Harris
Created Revert of Enable GPU Raster on OSX
4 years, 7 months ago (2016-05-17 09:51:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984183002/1
4 years, 7 months ago (2016-05-17 09:51:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984183002/1
4 years, 7 months ago (2016-05-17 10:01:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984183002/1
4 years, 7 months ago (2016-05-17 10:31:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 11:00:15 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 11:01:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f558620b78cc53d2a50d11b9d5bf94a229d2874
Cr-Commit-Position: refs/heads/master@{#394096}

Powered by Google App Engine
This is Rietveld 408576698