Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer.cc

Issue 1984173002: Log First User Interaction in Page Load Metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Logic refinements Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/browser/metrics_web_contents_observer.cc
diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer.cc b/components/page_load_metrics/browser/metrics_web_contents_observer.cc
index 7678a3f4ace6e08330d369f04b13909e94293bf4..78b08d1bcb9d7f58dd87053839928934ae0f2f1e 100644
--- a/components/page_load_metrics/browser/metrics_web_contents_observer.cc
+++ b/components/page_load_metrics/browser/metrics_web_contents_observer.cc
@@ -20,6 +20,7 @@
#include "content/public/browser/navigation_details.h"
#include "content/public/browser/navigation_handle.h"
#include "content/public/browser/render_frame_host.h"
+#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/browser/web_contents_user_data.h"
@@ -372,6 +373,12 @@ void PageLoadTracker::Redirect(content::NavigationHandle* navigation_handle) {
}
}
+void PageLoadTracker::OnInputEvent(const blink::WebInputEvent& event) {
+ for (const auto& observer : observers_) {
+ observer->OnUserInput(event);
+ }
+}
+
bool PageLoadTracker::UpdateTiming(const PageLoadTiming& new_timing,
const PageLoadMetadata& new_metadata) {
// Throw away IPCs that are not relevant to the current navigation.
@@ -508,7 +515,9 @@ MetricsWebContentsObserver::MetricsWebContentsObserver(
: content::WebContentsObserver(web_contents),
in_foreground_(false),
embedder_interface_(std::move(embedder_interface)),
- has_navigated_(false) {}
+ has_navigated_(false) {
+ RegisterInputEventObserver(web_contents->GetRenderViewHost());
+}
MetricsWebContentsObserver* MetricsWebContentsObserver::CreateForWebContents(
content::WebContents* web_contents,
@@ -528,6 +537,23 @@ MetricsWebContentsObserver::~MetricsWebContentsObserver() {
NotifyAbortAllLoads(ABORT_CLOSE);
}
+void MetricsWebContentsObserver::RegisterInputEventObserver(
+ content::RenderViewHost* host) {
+ host->GetWidget()->AddInputEventObserver(this);
+}
+
+void MetricsWebContentsObserver::UnregisterInputEventObserver(
+ content::RenderViewHost* host) {
+ host->GetWidget()->RemoveInputEventObserver(this);
+}
+
+void MetricsWebContentsObserver::RenderViewHostChanged(
+ content::RenderViewHost* old_host,
+ content::RenderViewHost* new_host) {
+ UnregisterInputEventObserver(old_host);
+ RegisterInputEventObserver(new_host);
+}
+
bool MetricsWebContentsObserver::OnMessageReceived(
const IPC::Message& message,
content::RenderFrameHost* render_frame_host) {
@@ -663,6 +689,20 @@ void MetricsWebContentsObserver::NavigationStopped() {
NotifyAbortAllLoads(ABORT_STOP);
}
+void MetricsWebContentsObserver::OnInputEvent(
+ const blink::WebInputEvent& event) {
+ // Ignore browser navigation or reload which comes with type Undefined.
+ if (event.type == blink::WebInputEvent::Type::Undefined)
+ return;
+
+ if (!committed_load_) {
+ RecordInternalError(ERR_USER_INPUT_WITH_NO_RELEVANT_LOAD);
+ return;
+ }
+
+ committed_load_->OnInputEvent(event);
+}
+
void MetricsWebContentsObserver::DidRedirectNavigation(
content::NavigationHandle* navigation_handle) {
if (!navigation_handle->IsInMainFrame())

Powered by Google App Engine
This is Rietveld 408576698