Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2447)

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

Issue 1984173002: Log First User Interaction in Page Load Metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Get navigation_start in OnCommit callback in FromGWSPLMO Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
index 94fc16dc255f5bf7135a097dba8247533f5bbd68..2717cdabc66faa115fb9b80721588377d1868077 100644
--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
@@ -47,6 +47,10 @@ class FromGWSPageLoadMetricsLogger {
navigation_initiated_via_link_ = navigation_initiated_via_link;
}
+ void SetNavigationStart(const base::TimeTicks navigation_start) {
+ navigation_start_ = navigation_start;
Bryan McQuade 2016/05/27 20:06:36 let's add DCHECK(navigation_start_.is_null()); at
mushan1 2016/05/28 03:58:32 Done.
+ }
+
// Invoked when metrics for the given page are complete.
void OnComplete(const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info);
@@ -70,6 +74,7 @@ class FromGWSPageLoadMetricsLogger {
const page_load_metrics::PageLoadExtraInfo& extra_info);
void OnParseStop(const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info);
+ void OnUserInput(const blink::WebInputEvent& event);
// The methods below are public only for testing.
static bool IsGoogleSearchHostname(base::StringPiece host);
@@ -102,6 +107,14 @@ class FromGWSPageLoadMetricsLogger {
bool provisional_url_has_search_hostname_ = false;
bool provisional_url_is_non_http_or_https_ = false;
+ // The state of if first paint is triggered.
+ bool first_paint_triggered_ = false;
+
+ base::TimeTicks navigation_start_;
+
+ // The time of first user interaction after paint from navigation start.
+ base::TimeDelta first_user_interaction_after_paint_;
+
// Common helper for QueryContainsComponent and QueryContainsComponentPrefix.
static bool QueryContainsComponentHelper(const base::StringPiece query,
const base::StringPiece component,
@@ -149,6 +162,8 @@ class FromGWSPageLoadMetricsObserver
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
+ void OnUserInput(const blink::WebInputEvent& event) override;
+
private:
FromGWSPageLoadMetricsLogger logger_;

Powered by Google App Engine
This is Rietveld 408576698