components/page_load_metrics/DEPS - Issue 1984173002: Log First User Interaction in Page Load Metrics

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/page_load_metrics/DEPS

Issue 1984173002: Log First User Interaction in Page Load Metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Logic refinements Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+content/public/test",	2 "+content/public/test",

3 "+ipc",	3 "+ipc",

4	4

5 "-components/page_load_metrics",	5 "-components/page_load_metrics",

6 "+components/page_load_metrics/common",	6 "+components/page_load_metrics/common",

7	7

8 # No inclusion of WebKit from the browser, other than strictly enum/POD, heade r-only types.	8 # No inclusion of WebKit from the browser, other than strictly enum/POD, heade r-only types.

9 "-third_party/WebKit",	9 "-third_party/WebKit",

10 "+third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h",	10 "+third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h",

	11 "+third_party/WebKit/public/web/WebInputEvent.h",
	Bryan McQuade 2016/05/28 12:23:29 since we only depend on this in browser code, and since we only depend on this in browser code, and I don't anticipate that changing, you can move this to components/page_load_metrics/browser/DEPS mushan1 2016/05/31 20:16:56 Done. Show quoted text On 2016/05/28 at 12:23:29, Bryan McQuade wrote: > since we only depend on this in browser code, and I don't anticipate that changing, you can move this to > components/page_load_metrics/browser/DEPS Done.
11 ]	12 ]

OLD	NEW