Workaround for flaky ax_enums.h errors when compiling under app_list_presenter

Workaround for flaky ax_enums.h errors when compiling under app_list_presenter

ui/views/view.h #includes ax_enums.h and app_list_presenter #includes
view.h. This means ax_enums.h needs to exist before anything in
app_list_presenter is compiled, even though app_list_presenter doesn't
use anything from ax_enums.h.

An alternative might be to make views.gyp:views a hard_dependency of
everything that depends on it. However, it seems unfair to force that,
since it's really only ax_gen that is the "hard" dependency, and it's
already correctly marked as a hard_dependency.

Exploring a nicer fix in http://crbug.com/612382, which involves view.h
simply not #including ax_enums.h

BUG=611898
Committed: https://crrev.com/93fa270c60338957b15cefb20e5553fb67cb2ba3
Cr-Commit-Position: refs/heads/master@{#394074}

[tapted, 2016-05-17 05:34:06]

Description was changed from

==========
Workaround for flaky ax_enums.h errors when compiling under app_list_presenter

ui/views/view.h #includes ax_enums.h and app_list_presenter #includes view.h.
This means ax_enums.h needs to exist before anything in app_list_presenter
is compiled, even though app_list_presenter doesn't use anything from
ax_enums.h.

An alternative might be to make views.gyp:views a hard_dependency of everything
that depends on it, but it seems unfair to force that, since it's really
only ax_gen that is the "hard" dependency, and it's already correctly
marked as a hard_dependency.

Exploring a nicer fix in http://crbug.com/612382, which involves view.h
simply not #including ax_enums.h

BUG=611898
==========

to

==========
Workaround for flaky ax_enums.h errors when compiling under app_list_presenter

ui/views/view.h #includes ax_enums.h and app_list_presenter #includes
view.h. This means ax_enums.h needs to exist before anything in
app_list_presenter is compiled, even though app_list_presenter doesn't
use anything from ax_enums.h.

An alternative might be to make views.gyp:views a hard_dependency of
everything that depends on it. However, it seems unfair to force that,
since it's really only ax_gen that is the "hard" dependency, and it's
already correctly marked as a hard_dependency.

Exploring a nicer fix in http://crbug.com/612382, which involves view.h
simply not #including ax_enums.h

BUG=611898
==========

[tapted, 2016-05-17 05:34:06]

tapted@chromium.org changed reviewers:
+ calamity@chromium.org

[calamity, 2016-05-17 07:10:46]

lgtm

[tapted, 2016-05-17 07:21:42]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-05-17 07:21:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984153002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984153002/20001

[commit-bot: I haz the power, 2016-05-17 07:25:43]

Description was changed from

==========
Workaround for flaky ax_enums.h errors when compiling under app_list_presenter

ui/views/view.h #includes ax_enums.h and app_list_presenter #includes
view.h. This means ax_enums.h needs to exist before anything in
app_list_presenter is compiled, even though app_list_presenter doesn't
use anything from ax_enums.h.

An alternative might be to make views.gyp:views a hard_dependency of
everything that depends on it. However, it seems unfair to force that,
since it's really only ax_gen that is the "hard" dependency, and it's
already correctly marked as a hard_dependency.

Exploring a nicer fix in http://crbug.com/612382, which involves view.h
simply not #including ax_enums.h

BUG=611898
==========

to

==========
Workaround for flaky ax_enums.h errors when compiling under app_list_presenter

ui/views/view.h #includes ax_enums.h and app_list_presenter #includes
view.h. This means ax_enums.h needs to exist before anything in
app_list_presenter is compiled, even though app_list_presenter doesn't
use anything from ax_enums.h.

An alternative might be to make views.gyp:views a hard_dependency of
everything that depends on it. However, it seems unfair to force that,
since it's really only ax_gen that is the "hard" dependency, and it's
already correctly marked as a hard_dependency.

Exploring a nicer fix in http://crbug.com/612382, which involves view.h
simply not #including ax_enums.h

BUG=611898
==========

[commit-bot: I haz the power, 2016-05-17 07:25:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-17 07:26:50]

Description was changed from

==========
Workaround for flaky ax_enums.h errors when compiling under app_list_presenter

ui/views/view.h #includes ax_enums.h and app_list_presenter #includes
view.h. This means ax_enums.h needs to exist before anything in
app_list_presenter is compiled, even though app_list_presenter doesn't
use anything from ax_enums.h.

An alternative might be to make views.gyp:views a hard_dependency of
everything that depends on it. However, it seems unfair to force that,
since it's really only ax_gen that is the "hard" dependency, and it's
already correctly marked as a hard_dependency.

Exploring a nicer fix in http://crbug.com/612382, which involves view.h
simply not #including ax_enums.h

BUG=611898
==========

to

==========
Workaround for flaky ax_enums.h errors when compiling under app_list_presenter

ui/views/view.h #includes ax_enums.h and app_list_presenter #includes
view.h. This means ax_enums.h needs to exist before anything in
app_list_presenter is compiled, even though app_list_presenter doesn't
use anything from ax_enums.h.

An alternative might be to make views.gyp:views a hard_dependency of
everything that depends on it. However, it seems unfair to force that,
since it's really only ax_gen that is the "hard" dependency, and it's
already correctly marked as a hard_dependency.

Exploring a nicer fix in http://crbug.com/612382, which involves view.h
simply not #including ax_enums.h

BUG=611898

Committed: https://crrev.com/93fa270c60338957b15cefb20e5553fb67cb2ba3
Cr-Commit-Position: refs/heads/master@{#394074}
==========

[commit-bot: I haz the power, 2016-05-17 07:26:51]

Patchset 2 (id:??) landed as
https://crrev.com/93fa270c60338957b15cefb20e5553fb67cb2ba3
Cr-Commit-Position: refs/heads/master@{#394074}