Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2858)

Unified Diff: ash/wm/system_gesture_event_filter.cc

Issue 198413003: Enable immersive fullscreen on Windows Ash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix some linux compile errors, and check USE_ASH instead of OS define. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/system_gesture_event_filter.cc
diff --git a/ash/wm/system_gesture_event_filter.cc b/ash/wm/system_gesture_event_filter.cc
index 1c318327a8ed85d384d1e8435cbaf28b291ba759..2499726d20d25d5eea17bfcba947b3a231c2c287 100644
--- a/ash/wm/system_gesture_event_filter.cc
+++ b/ash/wm/system_gesture_event_filter.cc
@@ -65,7 +65,9 @@ void SystemGestureEventFilter::OnGestureEvent(ui::GestureEvent* event) {
if (event->type() == ui::ET_GESTURE_WIN8_EDGE_SWIPE &&
shelf_gesture_handler_->ProcessGestureEvent(*event)) {
- event->StopPropagation();
+ // Do not stop propagation, since the immersive fullscreen controller may
+ // need to handle this event.
+ return;
pkotwicz 2014/03/13 18:34:32 Nits: - Return is unncessary given that this is th
zturner 2014/03/13 19:28:10 I put return here so that it is clear this should
}
}

Powered by Google App Engine
This is Rietveld 408576698