chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc - Issue 198413003: Enable immersive fullscreen on Windows Ash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

Issue 198413003: Enable immersive fullscreen on Windows Ash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix latest set of review issues. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

index 77a682c8d01a1f08d3292c7647cfff040a449029..394cdd21e652e023f7ebf253a6476973af9af9fd 100644

--- a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

+++ b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

@@ -1783,7 +1783,8 @@ IN_PROC_BROWSER_TEST_P(DetachToBrowserInSeparateDisplayTabDragControllerTest,

EXPECT_FALSE(browser2->window()->IsMaximized());

}

-// Immersive fullscreen is ChromeOS only.

+// Windows Ash does not support multiple displays, so this test only applies to

+// CrOS.

pkotwicz 2014/03/18 21:54:32 How about: "Immersive fullscreen is Ash only. Howe

zturner 2014/03/18 22:35:44 Done.

#if defined(OS_CHROMEOS)

// TODO(sky,sad): Disabled as it fails due to resize locks with a real

// compositor. crbug.com/331924

« no previous file with comments | « chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc ('k') | chrome/chrome_tests.gypi » ('j') | chrome/chrome_tests.gypi » ('J')