Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1984103004: DevTools: Add initiator field to timeline network events (Closed)

Created:
4 years, 7 months ago by alph
Modified:
4 years, 7 months ago
Reviewers:
caseq, paulirish
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Add initiator field to timeline network events BUG=612600 NOTRY=true Committed: https://crrev.com/67ba4100901ae84b5ffc11b4f415756dd1906cff Cr-Commit-Position: refs/heads/master@{#394824}

Patch Set 1 #

Patch Set 2 : add line number #

Patch Set 3 : update the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -29 lines) Patch
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-resource-details.html View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-resource-details-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 2 chunks +33 lines, -27 lines 0 comments Download

Messages

Total messages: 30 (16 generated)
alph
4 years, 7 months ago (2016-05-17 19:38:07 UTC) #2
caseq
I'm not sure if this is the kind of initiators that Paul has in mind ...
4 years, 7 months ago (2016-05-17 19:52:42 UTC) #3
alph
ptal
4 years, 7 months ago (2016-05-17 23:58:32 UTC) #6
alph
On 2016/05/17 19:52:42, caseq wrote: > I'm not sure if this is the kind of ...
4 years, 7 months ago (2016-05-18 22:14:50 UTC) #9
caseq
lgtm
4 years, 7 months ago (2016-05-19 00:19:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984103004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984103004/40001
4 years, 7 months ago (2016-05-19 00:42:00 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/224619)
4 years, 7 months ago (2016-05-19 05:47:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984103004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984103004/40001
4 years, 7 months ago (2016-05-19 06:02:24 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/224697)
4 years, 7 months ago (2016-05-19 09:14:12 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984103004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984103004/40001
4 years, 7 months ago (2016-05-19 14:46:07 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/224960)
4 years, 7 months ago (2016-05-19 18:35:41 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984103004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984103004/40001
4 years, 7 months ago (2016-05-19 18:39:36 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-19 18:44:26 UTC) #28
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 18:47:07 UTC) #30
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/67ba4100901ae84b5ffc11b4f415756dd1906cff
Cr-Commit-Position: refs/heads/master@{#394824}

Powered by Google App Engine
This is Rietveld 408576698