Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1984083003: Avoid using vtable of destroyed object in MultiBuffer unit test. (Closed)

Created:
4 years, 7 months ago by hubbe
Modified:
4 years, 7 months ago
Reviewers:
Dale Curtis, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, pcc1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid using vtable of destroyed object in MultiBuffer unit test. <EOM> BUG=612552 Committed: https://crrev.com/535814cb156da1f3872a1a605a9ec9108962533b Cr-Commit-Position: refs/heads/master@{#394231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M media/blink/multibuffer_data_source_unittest.cc View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
hubbe
4 years, 7 months ago (2016-05-17 19:50:01 UTC) #2
DaleCurtis
lgtm
4 years, 7 months ago (2016-05-17 20:15:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984083003/1
4 years, 7 months ago (2016-05-17 20:30:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 21:08:47 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 21:11:10 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/535814cb156da1f3872a1a605a9ec9108962533b
Cr-Commit-Position: refs/heads/master@{#394231}

Powered by Google App Engine
This is Rietveld 408576698