Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1394)

Issue 1984053003: Revert of Update export_tarball.py (Closed)

Created:
4 years, 7 months ago by qyearsley
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Update export_tarball.py (patchset #1 id:1 of https://codereview.chromium.org/1981553002/ ) Reason for revert: Failure in the export_tarball step Example build: https://build.chromium.org/p/chromium.infra.cron/builders/publish_tarball/builds/3466 Traceback (most recent call last): File "/b/build/scripts/slave/recipe_modules/chromium/resources/export_tarball.py", line 191, in <module> sys.exit(main(sys.argv[1:])) File "/b/build/scripts/slave/recipe_modules/chromium/resources/export_tarball.py", line 167, in main archive.add(options.src_dir, arcname=output_basename) File "/b/build/scripts/slave/recipe_modules/chromium/resources/export_tarball.py", line 100, in add rel_name = os.path.relpath(name, GetSourceDirectory()) NameError: global name 'GetSourceDirectory' is not defined Original issue's description: > Update export_tarball.py > > - Exclude .git directories only. Stop mentioning SVN. > - Exclude the out directory. > - Remove obsolete non-essential directories from the list. > - Move some non-essential directories to the test data list. > - Add a list of essential files to override the non-essential dir list. > > BUG=611199 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300596 TBR=phajdan.jr@chromium.org,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=611199 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300630

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -27 lines) Patch
M scripts/slave/recipe_modules/chromium/resources/export_tarball.py View 6 chunks +33 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
qyearsley
Created Revert of Update export_tarball.py
4 years, 7 months ago (2016-05-17 16:54:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984053003/1
4 years, 7 months ago (2016-05-17 16:54:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300630
4 years, 7 months ago (2016-05-17 16:55:11 UTC) #4
Lei Zhang
4 years, 7 months ago (2016-05-17 17:33:48 UTC) #5
Message was sent while issue was closed.
lgtm

Sigh. There must've been some copy+paste failure when I moved the code over from
the other export_tarball.py.

Powered by Google App Engine
This is Rietveld 408576698