Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: src/accessors.h

Issue 1984043002: Remove now-incorrect DataView accessor optimization (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/accessors.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_ACCESSORS_H_ 5 #ifndef V8_ACCESSORS_H_
6 #define V8_ACCESSORS_H_ 6 #define V8_ACCESSORS_H_
7 7
8 #include "include/v8.h" 8 #include "include/v8.h"
9 #include "src/allocation.h" 9 #include "src/allocation.h"
10 #include "src/globals.h" 10 #include "src/globals.h"
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 88
89 // Accessor infos. 89 // Accessor infos.
90 static Handle<AccessorInfo> MakeModuleExport( 90 static Handle<AccessorInfo> MakeModuleExport(
91 Handle<String> name, int index, PropertyAttributes attributes); 91 Handle<String> name, int index, PropertyAttributes attributes);
92 92
93 // Returns true for properties that are accessors to object fields. 93 // Returns true for properties that are accessors to object fields.
94 // If true, *object_offset contains offset of object field. 94 // If true, *object_offset contains offset of object field.
95 static bool IsJSObjectFieldAccessor(Handle<Map> map, Handle<Name> name, 95 static bool IsJSObjectFieldAccessor(Handle<Map> map, Handle<Name> name,
96 int* object_offset); 96 int* object_offset);
97 97
98 // Returns true for properties that are accessors to ArrayBufferView and
99 // derived classes fields. If true, *object_offset contains offset of
100 // object field. The caller still has to check whether the underlying
101 // buffer was neutered.
102 static bool IsJSArrayBufferViewFieldAccessor(Handle<Map> map,
103 Handle<Name> name,
104 int* object_offset);
105
106 static Handle<AccessorInfo> MakeAccessor( 98 static Handle<AccessorInfo> MakeAccessor(
107 Isolate* isolate, 99 Isolate* isolate,
108 Handle<Name> name, 100 Handle<Name> name,
109 AccessorNameGetterCallback getter, 101 AccessorNameGetterCallback getter,
110 AccessorNameSetterCallback setter, 102 AccessorNameSetterCallback setter,
111 PropertyAttributes attributes); 103 PropertyAttributes attributes);
112 }; 104 };
113 105
114 } // namespace internal 106 } // namespace internal
115 } // namespace v8 107 } // namespace v8
116 108
117 #endif // V8_ACCESSORS_H_ 109 #endif // V8_ACCESSORS_H_
OLDNEW
« no previous file with comments | « no previous file | src/accessors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698