Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1984043002: Remove now-incorrect DataView accessor optimization (Closed)

Created:
4 years, 7 months ago by adamk
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, gsathya
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove now-incorrect DataView accessor optimization In ES2015, the "byteLength" and "byteOffset" properties of DataViews are getters on the prototype, so the previously-used strategy of special-casing them using only the receiver map is invalid. A future CL will need to use the same strategy which will be taken for TypedArray "length", "byteLength", and "byteOffset": adding a prototype chain check. BUG=v8:5018, chromium:593634 Committed: https://crrev.com/de7d47e22f6296417300f712b3ff3d1a1cd6dba8 Cr-Commit-Position: refs/heads/master@{#36382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -86 lines) Patch
M src/accessors.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/accessors.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/compiler/access-info.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 3 chunks +0 lines, -18 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +0 lines, -9 lines 0 comments Download
A test/mjsunit/regress/regress-5018.js View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
adamk
Here's a warmup for our discussion tomorrow :)
4 years, 7 months ago (2016-05-17 00:01:14 UTC) #2
Toon Verwaest
lgtm
4 years, 7 months ago (2016-05-17 15:32:04 UTC) #4
adamk
+mstarzinger for compiler/OWNERS
4 years, 7 months ago (2016-05-18 19:31:45 UTC) #6
Michael Starzinger
LGTM on "compiler".
4 years, 7 months ago (2016-05-19 10:38:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984043002/1
4 years, 7 months ago (2016-05-19 19:18:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 19:48:05 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 19:49:43 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de7d47e22f6296417300f712b3ff3d1a1cd6dba8
Cr-Commit-Position: refs/heads/master@{#36382}

Powered by Google App Engine
This is Rietveld 408576698