Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: components/variations/variations_seed_processor_unittest.cc

Issue 1984003002: Use low entropy for studies that send experiment IDs to Google properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/variations/variations_seed_processor_unittest.cc
diff --git a/components/variations/variations_seed_processor_unittest.cc b/components/variations/variations_seed_processor_unittest.cc
index 5c54df657f0cb056a382e7cb3ca6fbb95d8b2486..402c3a858c89ebdef8be8b665162ff7c2e59ebeb 100644
--- a/components/variations/variations_seed_processor_unittest.cc
+++ b/components/variations/variations_seed_processor_unittest.cc
@@ -127,7 +127,7 @@ class VariationsSeedProcessorTest : public ::testing::Test {
ProcessedStudy processed_study;
if (processed_study.Init(study, false)) {
VariationsSeedProcessor().CreateTrialFromStudy(
- processed_study, override_callback_.callback(), feature_list);
+ processed_study, override_callback_.callback(), feature_list, NULL);
return true;
}
return false;
@@ -238,7 +238,7 @@ TEST_F(VariationsSeedProcessorTest,
seed_processor.CreateTrialsFromSeed(
seed, "en-CA", base::Time::Now(), version, Study_Channel_STABLE,
Study_FormFactor_DESKTOP, "", "", "", override_callback_.callback(),
- &feature_list);
+ &feature_list, NULL);
EXPECT_EQ(kGroup1Name, base::FieldTrialList::FindFullName(kTrialName));
}
@@ -252,7 +252,7 @@ TEST_F(VariationsSeedProcessorTest,
seed_processor.CreateTrialsFromSeed(
seed, "en-CA", base::Time::Now(), version, Study_Channel_STABLE,
Study_FormFactor_DESKTOP, "", "", "", override_callback_.callback(),
- &feature_list);
+ &feature_list, NULL);
EXPECT_EQ(kGroup1Name, base::FieldTrialList::FindFullName(kTrialName));
}
}
@@ -500,7 +500,7 @@ TEST_F(VariationsSeedProcessorTest, StartsActive) {
seed_processor.CreateTrialsFromSeed(
seed, "en-CA", base::Time::Now(), base::Version("20.0.0.0"),
Study_Channel_STABLE, Study_FormFactor_DESKTOP, "", "", "",
- override_callback_.callback(), &feature_list_);
+ override_callback_.callback(), &feature_list_, NULL);
// Non-specified and ACTIVATION_EXPLICIT should not start active, but
// ACTIVATION_AUTO should.

Powered by Google App Engine
This is Rietveld 408576698