Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: components/variations/service/variations_service_unittest.cc

Issue 1984003002: Use low entropy for studies that send experiment IDs to Google properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/variations/service/variations_service_unittest.cc
diff --git a/components/variations/service/variations_service_unittest.cc b/components/variations/service/variations_service_unittest.cc
index 4e1f77d13bf67d5c251230308cf6b84927f7dfff..6abfc8a8f5c16297da3c3e6bf97d86d5037dca91 100644
--- a/components/variations/service/variations_service_unittest.cc
+++ b/components/variations/service/variations_service_unittest.cc
@@ -133,6 +133,11 @@ class TestVariationsService : public VariationsService {
return true;
}
+ std::unique_ptr<const base::FieldTrial::EntropyProvider>
+ CreateLowEntropyProvider() override {
+ return std::unique_ptr<const base::FieldTrial::EntropyProvider>(nullptr);
+ }
+
private:
bool LoadSeed(VariationsSeed* seed) override {
if (!seed_stored_)
@@ -290,8 +295,8 @@ TEST_F(VariationsServiceTest, CreateTrialsFromSeed) {
// Check that field trials are created from the seed. Since the test study has
// only 1 experiment with 100% probability weight, we must be part of it.
EXPECT_TRUE(service.CreateTrialsFromSeed(base::FeatureList::GetInstance()));
- EXPECT_EQ(base::FieldTrialList::FindFullName(kTestSeedStudyName),
- kTestSeedExperimentName);
+ EXPECT_EQ(kTestSeedExperimentName,
+ base::FieldTrialList::FindFullName(kTestSeedStudyName));
}
TEST_F(VariationsServiceTest, CreateTrialsFromSeedNoLastFetchTime) {
« no previous file with comments | « components/variations/service/variations_service.cc ('k') | components/variations/variations_seed_processor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698