components/variations/service/variations_service.h - Issue 1984003002: Use low entropy for studies that send experiment IDs to Google properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/variations/service/variations_service.h

Issue 1984003002: Use low entropy for studies that send experiment IDs to Google properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/metrics/metrics_state_manager.cc ('K') | « components/variations/entropy_provider_unittest.cc ('k') | components/variations/service/variations_service.cc » ('j') | components/variations/variations_seed_processor.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/variations/service/variations_service.h

diff --git a/components/variations/service/variations_service.h b/components/variations/service/variations_service.h

index 4d3c282ff640cf9350c5526e2be015eb51323982..44ec38af147f65b6a12f32965e57950fbc3ca91f 100644

--- a/components/variations/service/variations_service.h

+++ b/components/variations/service/variations_service.h

@@ -178,6 +178,12 @@ class VariationsService

bool is_delta_compressed,

bool is_gzip_compressed);

+ // Create an entropy provider based on low entropy. This is used to create

+ // trials for studies that should only depend on low entropy, such as studies

+ // that send experiment IDs to Google web properties. Exposed for testing.

Alexei Svitkine (slow) 2016/05/18 15:03:30 Nit: "Exposed for testing." -> "Virtual for testin

jwd 2016/05/18 18:31:41 Done.

+ virtual std::unique_ptr<const base::FieldTrial::EntropyProvider>

+ CreateLowEntropyProvider();

// Creates the VariationsService with the given |local_state| prefs service

// and |state_manager|. Does not take ownership of |state_manager|. Caller

// should ensure that |state_manager| is valid for the lifetime of this class.