Use low entropy for studies that send experiment IDs to Google properties.

components/variations/variations_seed_processor.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_VARIATIONS_VARIATIONS_SEED_PROCESSOR_H_
 #define COMPONENTS_VARIATIONS_VARIATIONS_SEED_PROCESSOR_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 22 matching lines @@
 class VariationsSeedProcessor {
  public:
   typedef base::Callback<void(uint32_t, const base::string16&)>
       UIStringOverrideCallback;
 
   VariationsSeedProcessor();
   virtual ~VariationsSeedProcessor();
 
   // Creates field trials from the specified variations |seed|, based on the
   // specified configuration, as specified in the parameters.
-  void CreateTrialsFromSeed(const VariationsSeed& seed,
-                            const std::string& locale,
-                            const base::Time& reference_date,
-                            const base::Version& version,
-                            Study_Channel channel,
-                            Study_FormFactor form_factor,
-                            const std::string& hardware_class,
-                            const std::string& session_consistency_country,
-                            const std::string& permanent_consistency_country,
-                            const UIStringOverrideCallback& override_callback,
-                            base::FeatureList* feature_list);
+  void CreateTrialsFromSeed(
+      const VariationsSeed& seed,
+      const std::string& locale,
+      const base::Time& reference_date,
+      const base::Version& version,
+      Study_Channel channel,
+      Study_FormFactor form_factor,
+      const std::string& hardware_class,
+      const std::string& session_consistency_country,
+      const std::string& permanent_consistency_country,
+      const UIStringOverrideCallback& override_callback,
+      base::FeatureList* feature_list,

[Alexei Svitkine (slow), 2016/05/18 15:03:30]

Nit: This non-const param should be last.

[jwd, 2016/05/18 18:31:41]

Done.

+      const base::FieldTrial::EntropyProvider* low_entropy_provider);
+
+  static bool ShouldStudyUseLowEntropy(const Study& study);

[Alexei Svitkine (slow), 2016/05/18 15:03:31]

Nit: Add a comment.

[jwd, 2016/05/18 18:31:41]

Done.

 
  private:
   friend class VariationsSeedProcessorTest;
   FRIEND_TEST_ALL_PREFIXES(VariationsSeedProcessorTest,
                            AllowForceGroupAndVariationId);
   FRIEND_TEST_ALL_PREFIXES(VariationsSeedProcessorTest,
                            AllowVariationIdWithForcingFlag);
   FRIEND_TEST_ALL_PREFIXES(VariationsSeedProcessorTest,
                            ForbidForceGroupWithVariationId);
   FRIEND_TEST_ALL_PREFIXES(VariationsSeedProcessorTest, ForceGroupWithFlag1);
   FRIEND_TEST_ALL_PREFIXES(VariationsSeedProcessorTest, ForceGroupWithFlag2);
   FRIEND_TEST_ALL_PREFIXES(VariationsSeedProcessorTest,
                            ForceGroup_ChooseFirstGroupWithFlag);
   FRIEND_TEST_ALL_PREFIXES(VariationsSeedProcessorTest,
                            ForceGroup_DontChooseGroupWithFlag);
   FRIEND_TEST_ALL_PREFIXES(VariationsSeedProcessorTest, IsStudyExpired);
   FRIEND_TEST_ALL_PREFIXES(VariationsSeedProcessorTest, VariationParams);
   FRIEND_TEST_ALL_PREFIXES(VariationsSeedProcessorTest,
                            VariationParamsWithForcingFlag);
 
   // Check if the |study| is only associated with platform Android/iOS and
   // channel dev/canary. If so, forcing flag and variation id can both be set.
   // (Otherwise, forcing_flag and variation_id are mutually exclusive.)
   bool AllowVariationIdWithForcingFlag(const Study& study);
 
   // Creates and registers a field trial from the |processed_study| data.
-  // Disables the trial if |processed_study.is_expired| is true.
-  void CreateTrialFromStudy(const ProcessedStudy& processed_study,
-                            const UIStringOverrideCallback& override_callback,
-                            base::FeatureList* feature_list);
+  // Disables the trial if |processed_study.is_expired| is true. Uses
+  // |low_entropy_provider| if ShouldStudyUseLowEntropy returns true for the
+  // study.

[Alexei Svitkine (slow), 2016/05/18 15:03:31]

Nit: Add the same comment to CreateTrialsFromSeed().

[jwd, 2016/05/18 18:31:41]

Done.

+  void CreateTrialFromStudy(
+      const ProcessedStudy& processed_study,
+      const UIStringOverrideCallback& override_callback,
+      const base::FieldTrial::EntropyProvider* low_entropy_provider,
+      base::FeatureList* feature_list);
 
   DISALLOW_COPY_AND_ASSIGN(VariationsSeedProcessor);
 };
 
 }  // namespace variations
 
 #endif  // COMPONENTS_VARIATIONS_VARIATIONS_SEED_PROCESSOR_H_