Revert "Gclient: Don't check if repository is clean if --force is passed in"

Revert "Gclient: Don't check if repository is clean if --force is passed in"

This reverts commit 3f0dacf095df6f73a2c54a8a9fb35c1c441a2fe1.

Reason for revert:
Is causing staged changes to be reverted.

BUG=607913
TBR=hinoka,dnj

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=300598

[smut, 2016-05-16 19:00:51]

smut@google.com changed reviewers:
+ dnj@chromium.org, hinoka@chromium.org

[smut, 2016-05-16 19:01:00]

Description was changed from

==========
Revert "Gclient: Don't check if repository is clean if --force is passed in"

This reverts commit 3f0dacf095df6f73a2c54a8a9fb35c1c441a2fe1.

Reason for revert:
Is causing staged changes to be reverted.

BUG=607913
==========

to

==========
Revert "Gclient: Don't check if repository is clean if --force is passed in"

This reverts commit 3f0dacf095df6f73a2c54a8a9fb35c1c441a2fe1.

Reason for revert:
Is causing staged changes to be reverted.

BUG=607913
TBR=hinoka,dnj
==========

[smut, 2016-05-16 19:06:09]

Description was changed from

==========
Revert "Gclient: Don't check if repository is clean if --force is passed in"

This reverts commit 3f0dacf095df6f73a2c54a8a9fb35c1c441a2fe1.

Reason for revert:
Is causing staged changes to be reverted.

BUG=607913
TBR=hinoka,dnj
==========

to

==========
Revert "Gclient: Don't check if repository is clean if --force is passed in"

This reverts commit 3f0dacf095df6f73a2c54a8a9fb35c1c441a2fe1.

Reason for revert:
Is causing staged changes to be reverted.

BUG=607913
TBR=hinoka,dnj

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=300598
==========

[smut, 2016-05-16 19:06:10]

Committed patchset #1 (id:1) manually as 300598.

[hinoka, 2016-05-16 19:40:37]

What is this breaking? And who's expecting staged changes to not be reverted if
--force is passed in?

[hinoka, 2016-05-16 19:41:58]

Oh i see the bug

On Mon, May 16, 2016 at 12:40 PM, <hinoka@chromium.org> wrote:

> What is this breaking? And who's expecting staged changes to not be
> reverted if
> --force is passed in?
>
> https://codereview.chromium.org/1983963002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[smut, 2016-05-16 19:45:08]

On 2016/05/16 19:40:37, hinoka wrote:
> What is this breaking? And who's expecting staged changes to not be reverted
if
> --force is passed in?

See #2 in the bug. Note that you were reverting staged changes even when --force
was not passed in.