Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1983863003: views: Initialize DesktopScreenX11::primary_display_index_. (Closed)

Created:
4 years, 7 months ago by sadrul
Modified:
4 years, 7 months ago
CC:
chromium-reviews, tfarina, Tom Anderson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views: Initialize DesktopScreenX11::primary_display_index_. The new field was introduced in crrev.com/391625, but this field was left uninitialized in this ctor. BUG=42313 Committed: https://crrev.com/71017aa70fb2feaa60c8178e253b100969800b63 Cr-Commit-Position: refs/heads/master@{#393985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sadrul
4 years, 7 months ago (2016-05-16 23:15:31 UTC) #2
Tom (Use chromium acct)
On 2016/05/16 23:15:31, sadrul wrote: lgtm, but how did this get removed? https://chromium.googlesource.com/chromium/src/+/d602774dbdcabb71f321f6d8a860fad39030fbad%5E%21/#F2
4 years, 7 months ago (2016-05-16 23:23:16 UTC) #3
Tom (Use chromium acct)
On 2016/05/16 23:23:16, Tom Anderson wrote: > On 2016/05/16 23:15:31, sadrul wrote: > > lgtm, ...
4 years, 7 months ago (2016-05-16 23:26:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983863003/1
4 years, 7 months ago (2016-05-16 23:51:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 23:55:45 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/71017aa70fb2feaa60c8178e253b100969800b63 Cr-Commit-Position: refs/heads/master@{#393985}
4 years, 7 months ago (2016-05-16 23:56:50 UTC) #9
qyearsley
4 years, 7 months ago (2016-05-17 23:18:27 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1985283002/ by qyearsley@chromium.org.

The reason for reverting is: Speculative revert to see if reverting this affects
the tests on Windows 7 (Dbg)(1) http://crbug.com/612523.

Powered by Google App Engine
This is Rietveld 408576698