Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: third_party/WebKit/Source/core/paint/TableCellPainter.h

Issue 1983853003: Refactor background painting behind table cells (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/TableCellPainter.h
diff --git a/third_party/WebKit/Source/core/paint/TableCellPainter.h b/third_party/WebKit/Source/core/paint/TableCellPainter.h
index 6a814e49af1c4e5b43c03280d2c12b2bfe1be129..b7c91db37ea50507cdf67c74077d2686e5b4ca85 100644
--- a/third_party/WebKit/Source/core/paint/TableCellPainter.h
+++ b/third_party/WebKit/Source/core/paint/TableCellPainter.h
@@ -27,16 +27,14 @@ public:
void paint(const PaintInfo&, const LayoutPoint&);
void paintCollapsedBorders(const PaintInfo&, const LayoutPoint&, const CollapsedBorderValue&);
- void paintBackgroundsBehindCell(const PaintInfo&, const LayoutPoint&, const LayoutObject* backgroundObject, DisplayItem::Type);
+ void paintContainerBackgroundBehindCell(const PaintInfo&, const LayoutPoint&, const LayoutObject& backgroundObject, DisplayItem::Type);
void paintBoxDecorationBackground(const PaintInfo&, const LayoutPoint& paintOffset);
void paintMask(const PaintInfo&, const LayoutPoint& paintOffset);
- enum PaintBoundOffsetBehavior { AddOffsetFromParent, DoNotAddOffsetFromParent };
- // Returns the bonds of the table cell for painting, offset by paintOffset, and if desired, the offset from the cell
- // to its parent.
- LayoutRect paintBounds(const LayoutPoint& paintOffset, PaintBoundOffsetBehavior);
-
private:
+ LayoutRect paintRectNotIncludingVisualOverflow(const LayoutPoint& paintOffset);
+ void paintBackground(const PaintInfo&, const LayoutRect&, const LayoutObject& backgroundObject);
+
const LayoutTableCell& m_layoutTableCell;
};

Powered by Google App Engine
This is Rietveld 408576698