third_party/libpng/README.google - Issue 1983853002: Update libpng to 1.6.22rc01

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libpng/README.google

Issue 1983853002: Update libpng to 1.6.22rc01 (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Added README.google and updated a bug Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 URL: http://www.libpng.org/pub/png/libpng.html	1 URL: http://www.libpng.org/pub/png/libpng.html

2 Version: 1.6.16	2 Version: 1.6.16

3 License: libpng license	3 License: libpng license

4 License File: LICENSE, pulled out of png.h	4 License File: LICENSE, pulled out of png.h

5 Description: png compression/decompression library	5 Description: png compression/decompression library

6 Local Modifications: (1) Created pnglibconf.h from pnglibconf.h.prebuilt (a	6 Local Modifications:

7 rename with a few additional settings enabled). (2) Copied LICENSE into	7 (1) Created pnglibconf.h from pnglibconf.h.prebuilt (a

8 this directory. (Originally it was pulled from png.h, but libpng has	8 rename with a few additional settings enabled).

9 now provided a separate LICENSE file for convenience, which we use	9 (2) Copied LICENSE into this directory. (Originally it

	10 was pulled from png.h, but libpng has now provided a

	11 separate LICENSE file for convenience, which we use

10 directly.)	12 directly.)

	13 (3) Included Intel optimizations by running:

	14 "patch -i contrib/intel/intel_sse.patch -p1"

11	15

12 FAQ:	16 FAQ:

13 Q: Why does this directory exist?	17 Q: Why does this directory exist?

14 A: libpng is pulled in through DEPS, but in order to build it using ninja, we	18 A: libpng is pulled in through DEPS, but in order to build it using ninja, we

15 need to create pnglibconf.h. We originally tried creating	19 need to create pnglibconf.h. We originally tried creating

16 the file as an action in https://codereview.chromium.org/930283002/, but this	20 the file as an action in https://codereview.chromium.org/930283002/, but this

17 apparently led to a race condition on Windows, where some builds failed to	21 apparently led to a race condition on Windows, where some builds failed to

18 create the file in time for other files to include it. By checking these	22 create the file in time for other files to include it. By checking these

19 files directly into Skia, we eliminate the race condition.	23 files directly into Skia, we eliminate the race condition.

OLD	NEW

« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »