Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(74)

Issue 198383002: Reland "Enable Object.observe by default" again (Closed)

Created:
6 years, 4 months ago by adamk
Modified:
6 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Reland "Enable Object.observe by default" again This re-re-re-lands enabling Object.observe. The Chromium tests that failed last time this was rolled into Chromium have been disabled in https://src.chromium.org/viewvc/chrome?view=revision&revision=256706 This patch should be safe to merge once that lands. BUG=v8:2409 LOG=Y TBR=rossberg@chromium.org,dslomov@chromium.org,rafaelw@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19868

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -2005 lines) Patch
M src/accessors.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M src/flag-definitions.h View 3 chunks +0 lines, -4 lines 0 comments Download
M src/ic.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/object-observe.js View 7 chunks +97 lines, -51 lines 0 comments Download
M src/objects.cc View 10 chunks +10 lines, -15 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +13 lines, -10 lines 0 comments Download
M test/cctest/test-microtask-delivery.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-object-observe.cc View 25 chunks +78 lines, -116 lines 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es7/object-observe.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/mjsunit/harmony/object-observe.js View 1 chunk +0 lines, -1789 lines 0 comments Download
M test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
adamk
Committed patchset #1 manually as r19868 (presubmit successful).
6 years, 4 months ago (2014-03-13 00:20:15 UTC) #1
Dmitry Lomov (no reviews)
Are we positively sure that the failure is tests-only?
6 years, 4 months ago (2014-03-13 07:50:56 UTC) #2
adamk
6 years, 4 months ago (2014-03-13 15:54:19 UTC) #3
Message was sent while issue was closed.
On 2014/03/13 07:50:56, Dmitry Lomov (chromium) wrote:
> Are we positively sure that the failure is tests-only?

No, I am not positively sure. Per my comments on the bug, the thing I'm sure
about is that the Chromium test (and/or feature) is breaking due to a dependency
on Polymer, and that dependency isn't something we can let hold up rolling
forward with web features that Polymer itself depends upon (otherwise we'll be
stuck in a Catch-22).

Powered by Google App Engine
This is Rietveld 408576698