Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2700)

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 1983803002: Added notification when user presses backspace to use new shortcut. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@subtle-notification-view-refactor
Patch Set: Respond to pkasting review. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_command_controller.cc
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc
index 87f1fe6275bcae838258c55855a4f0be5d2d10a0..5d97b8ff461ae14572d5f7b648dc4b21dd149d89 100644
--- a/chrome/browser/ui/browser_command_controller.cc
+++ b/chrome/browser/ui/browser_command_controller.cc
@@ -321,14 +321,20 @@ void BrowserCommandController::ExecuteCommandWithDisposition(
switch (id) {
// Navigation commands
case IDC_BACKSPACE_BACK:
- if (!base::FeatureList::IsEnabled(kBackspaceGoesBackFeature))
+ if (!base::FeatureList::IsEnabled(kBackspaceGoesBackFeature)) {
+ browser_->window()->ShowNewBackShortcutBubble(false);
Matt Giuca 2016/05/23 04:22:57 As noted on https://codereview.chromium.org/199200
Peter Kasting 2016/05/24 23:35:08 I think what you've done is fine.
break;
+ }
+ // FALL THROUGH
case IDC_BACK:
GoBack(browser_, disposition);
break;
case IDC_BACKSPACE_FORWARD:
- if (!base::FeatureList::IsEnabled(kBackspaceGoesBackFeature))
+ if (!base::FeatureList::IsEnabled(kBackspaceGoesBackFeature)) {
+ browser_->window()->ShowNewBackShortcutBubble(true);
break;
+ }
+ // FALL THROUGH
case IDC_FORWARD:
GoForward(browser_, disposition);
break;

Powered by Google App Engine
This is Rietveld 408576698