Added notification when user presses backspace to use new shortcut.

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 967 matching lines @@
 
 void BrowserView::UpdateExclusiveAccessExitBubbleContent(
     const GURL& url,
     ExclusiveAccessBubbleType bubble_type) {
   // Immersive mode has no exit bubble because it has a visible strip at the
   // top that gives the user a hover target.
   // TODO(jamescook): Figure out what to do with mouse-lock.
   if (bubble_type == EXCLUSIVE_ACCESS_BUBBLE_TYPE_NONE ||
       ShouldUseImmersiveFullscreenForUrl(url)) {
     exclusive_access_bubble_.reset();
-  } else if (exclusive_access_bubble_.get()) {
+    return;
+  }
+
+  // Hide the backspace shortcut bubble, to avoid overlapping.
+  backspace_new_shortcut_bubble_.reset();
+
+  if (exclusive_access_bubble_.get()) {

[Peter Kasting, 2016/05/19 10:08:37]

Nit: .get() not necessary

[Matt Giuca, 2016/05/23 04:22:57]

Done.

     exclusive_access_bubble_->UpdateContent(url, bubble_type);
-  } else {
-    exclusive_access_bubble_.reset(
-        new ExclusiveAccessBubbleViews(this, url, bubble_type));
+    return;
   }
+
+  exclusive_access_bubble_.reset(
+      new ExclusiveAccessBubbleViews(this, url, bubble_type));
 }
 
 void BrowserView::OnExclusiveAccessUserInput() {
   if (exclusive_access_bubble_.get())
     exclusive_access_bubble_->OnUserInput();
 }
 
 bool BrowserView::ShouldHideUIForFullscreen() const {
   // Immersive mode needs UI for the slide-down top panel.
   if (immersive_mode_controller_->IsEnabled())
@@ skipping 14 matching lines @@
   WebContents* selected_web_contents = GetActiveWebContents();
   if (selected_web_contents)
     selected_web_contents->RestoreFocus();
 }
 
 void BrowserView::FullscreenStateChanged() {
   CHECK(!IsFullscreen());
   ProcessFullscreen(false, GURL(), EXCLUSIVE_ACCESS_BUBBLE_TYPE_NONE);
 }
 
+void BrowserView::ShowBackspaceNewShortcutBubble(bool forward) {

[Peter Kasting, 2016/05/19 10:08:37]

Nit: Function definition order must match the declaration order in the .h file.

[Matt Giuca, 2016/05/23 04:22:57]

There is already significant discrepancy between the declaration order in the .h
file and the .cc file (FullscreenStateChanged and RestoreFocus are right at the
top in the .h file, but down here in the .cc file). This was my attempt at
placing the new function after all the Fullscreen logic, but I'll just move it
up after IsFullscreenBubbleVisible.

[Peter Kasting, 2016/05/24 23:35:08]

Yeah :(

I would love to see a CL that fixes all of browser_view.cc, but it would
definitely have to be separate.

+  // Hide the exclusive access bubble, to avoid overlapping.
+  exclusive_access_bubble_.reset();
+
+  if (backspace_new_shortcut_bubble_.get()) {

[Peter Kasting, 2016/05/19 10:08:37]

Nit: .get() not necessary

[Matt Giuca, 2016/05/23 04:22:57]

Done.

+    backspace_new_shortcut_bubble_->UpdateContent(forward);
+    return;
+  }
+
+  backspace_new_shortcut_bubble_.reset(
+      new BackspaceNewShortcutBubble(this, forward));
+}
+
 LocationBar* BrowserView::GetLocationBar() const {
   return GetLocationBarView();
 }
 
 void BrowserView::SetFocusToLocationBar(bool select_all) {
   // On Windows, changing focus to the location bar causes the browser
   // window to become active. This can steal focus if the user has
   // another window open already. On ChromeOS, changing focus makes a
   // view believe it has a focus even if the widget doens't have a
   // focus. Either cases, we need to ignore this when the browser
@@ skipping 1598 matching lines @@
 }
 
 extensions::ActiveTabPermissionGranter*
 BrowserView::GetActiveTabPermissionGranter() {
   content::WebContents* web_contents = GetActiveWebContents();
   if (!web_contents)
     return nullptr;
   return extensions::TabHelper::FromWebContents(web_contents)
       ->active_tab_permission_granter();
 }