Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 1983803002: Added notification when user presses backspace to use new shortcut. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@subtle-notification-view-refactor
Patch Set: Use UTF-16 instead of many UTF-8 conversions. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h" 5 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #import "base/mac/sdk_forward_declarations.h" 10 #import "base/mac/sdk_forward_declarations.h"
(...skipping 415 matching lines...) Expand 10 before | Expand all | Expand 10 after
426 } 426 }
427 427
428 bool BrowserWindowCocoa::IsFullscreen() const { 428 bool BrowserWindowCocoa::IsFullscreen() const {
429 return [controller_ isInAnyFullscreenMode]; 429 return [controller_ isInAnyFullscreenMode];
430 } 430 }
431 431
432 bool BrowserWindowCocoa::IsFullscreenBubbleVisible() const { 432 bool BrowserWindowCocoa::IsFullscreenBubbleVisible() const {
433 return false; // Currently only called from toolkit-views website_settings. 433 return false; // Currently only called from toolkit-views website_settings.
434 } 434 }
435 435
436 void TestBrowserWindow::ShowBackspaceNewShortcutBubble(bool forward) {
437 // Backspace new shortcut bubble not supported on Mac.
438 // https://crbug.com/610039.
439 }
440
436 LocationBar* BrowserWindowCocoa::GetLocationBar() const { 441 LocationBar* BrowserWindowCocoa::GetLocationBar() const {
437 return [controller_ locationBarBridge]; 442 return [controller_ locationBarBridge];
438 } 443 }
439 444
440 void BrowserWindowCocoa::SetFocusToLocationBar(bool select_all) { 445 void BrowserWindowCocoa::SetFocusToLocationBar(bool select_all) {
441 [controller_ focusLocationBar:select_all ? YES : NO]; 446 [controller_ focusLocationBar:select_all ? YES : NO];
442 } 447 }
443 448
444 void BrowserWindowCocoa::UpdateReloadStopState(bool is_loading, bool force) { 449 void BrowserWindowCocoa::UpdateReloadStopState(bool is_loading, bool force) {
445 [controller_ setIsLoading:is_loading force:force]; 450 [controller_ setIsLoading:is_loading force:force];
(...skipping 382 matching lines...) Expand 10 before | Expand all | Expand 10 after
828 ExclusiveAccessContext* BrowserWindowCocoa::GetExclusiveAccessContext() { 833 ExclusiveAccessContext* BrowserWindowCocoa::GetExclusiveAccessContext() {
829 return [controller_ exclusiveAccessController]; 834 return [controller_ exclusiveAccessController];
830 } 835 }
831 836
832 void BrowserWindowCocoa::ShowImeWarningBubble( 837 void BrowserWindowCocoa::ShowImeWarningBubble(
833 const extensions::Extension* extension, 838 const extensions::Extension* extension,
834 const base::Callback<void(ImeWarningBubblePermissionStatus status)>& 839 const base::Callback<void(ImeWarningBubblePermissionStatus status)>&
835 callback) { 840 callback) {
836 NOTREACHED() << "The IME warning bubble is unsupported on this platform."; 841 NOTREACHED() << "The IME warning bubble is unsupported on this platform.";
837 } 842 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698