Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 1983793002: Remove OwnPtr::release() calls in platform/ (part 2). (Closed)

Created:
4 years, 7 months ago by Yuta Kitamura
Modified:
4 years, 7 months ago
Reviewers:
*haraken, *tzik
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, kinuko+watch, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove OwnPtr::release() calls in platform/ (part 2). OwnPtr::release() calls can be (1) replaced with std::move(), or (2) removed entirely (in certain "return" statements). BUG=611660 Committed: https://crrev.com/20cd5a39df58894c38a6581bd40ae3bfa0d37c8c Cr-Commit-Position: refs/heads/master@{#394058}

Patch Set 1 #

Patch Set 2 : Add one more file. #

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983793002/1
4 years, 7 months ago (2016-05-16 06:37:04 UTC) #2
Yuta Kitamura
tzik: PTAL? +haraken for platform/ approval.
4 years, 7 months ago (2016-05-16 06:38:21 UTC) #5
haraken
LGTM
4 years, 7 months ago (2016-05-16 06:46:54 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983793002/20001
4 years, 7 months ago (2016-05-16 06:51:09 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-16 08:25:36 UTC) #10
tzik
lgtm
4 years, 7 months ago (2016-05-17 04:55:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983793002/20001
4 years, 7 months ago (2016-05-17 05:14:31 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-17 05:18:13 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 05:20:50 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/20cd5a39df58894c38a6581bd40ae3bfa0d37c8c
Cr-Commit-Position: refs/heads/master@{#394058}

Powered by Google App Engine
This is Rietveld 408576698