Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: components/search_engines/template_url_prepopulate_data_unittest.cc

Issue 1983773002: Cache SearchEngineType of TemplateURL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-extracting-terms-from-template-url
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/template_url_prepopulate_data_unittest.cc
diff --git a/components/search_engines/template_url_prepopulate_data_unittest.cc b/components/search_engines/template_url_prepopulate_data_unittest.cc
index 368597b9ff352803245dc726504a5122f76a8127..db317cf6a7c9da1e06fbcb7470189582d044ebe4 100644
--- a/components/search_engines/template_url_prepopulate_data_unittest.cc
+++ b/components/search_engines/template_url_prepopulate_data_unittest.cc
@@ -26,8 +26,7 @@ namespace {
SearchEngineType GetEngineType(const std::string& url) {
TemplateURLData data;
data.SetURL(url);
- return TemplateURLPrepopulateData::GetEngineType(TemplateURL(data),
- SearchTermsData());
+ return TemplateURL(data).GetEngineType(SearchTermsData());
}
std::string GetHostFromTemplateURLData(const TemplateURLData& data) {
@@ -248,8 +247,7 @@ TEST_F(TemplateURLPrepopulateDataTest, ClearProvidersFromPrefs) {
EXPECT_FALSE(t_urls[default_index]->contextual_search_url.empty());
EXPECT_FALSE(t_urls[default_index]->image_url_post_params.empty());
EXPECT_EQ(SEARCH_ENGINE_GOOGLE,
- TemplateURLPrepopulateData::GetEngineType(
- TemplateURL(*t_urls[default_index]),
+ TemplateURL(*t_urls[default_index]).GetEngineType(
SearchTermsData()));
}
@@ -287,8 +285,7 @@ TEST_F(TemplateURLPrepopulateDataTest, ProvidersFromPrepopulated) {
for (size_t i = 0; i < t_urls[default_index]->alternate_urls.size(); ++i)
EXPECT_FALSE(t_urls[default_index]->alternate_urls[i].empty());
EXPECT_EQ(SEARCH_ENGINE_GOOGLE,
- TemplateURLPrepopulateData::GetEngineType(
- TemplateURL(*t_urls[default_index]),
+ TemplateURL(*t_urls[default_index]).GetEngineType(
SearchTermsData()));
EXPECT_FALSE(t_urls[default_index]->search_terms_replacement_key.empty());
}

Powered by Google App Engine
This is Rietveld 408576698