chrome/browser/ui/app_list/app_list_view_delegate.cc - Issue 1983773002: Cache SearchEngineType of TemplateURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_list_view_delegate.cc

Issue 1983773002: Cache SearchEngineType of TemplateURL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-extracting-terms-from-template-url

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/search/local_ntp_source.cc ('k') | chrome/browser/ui/app_list/start_page_service.cc » ('j') | components/search_engines/keyword_table.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/app_list_view_delegate.cc

diff --git a/chrome/browser/ui/app_list/app_list_view_delegate.cc b/chrome/browser/ui/app_list/app_list_view_delegate.cc

index 0b77b21519ffb983c251b9e564e1d790208723fa..e9e96fe3649255c6dde1cda6d61bd9aa9cf8fbba 100644

--- a/chrome/browser/ui/app_list/app_list_view_delegate.cc

+++ b/chrome/browser/ui/app_list/app_list_view_delegate.cc

@@ -43,7 +43,6 @@

#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

#include "components/prefs/pref_service.h"

-#include "components/search_engines/template_url_prepopulate_data.h"

#include "components/signin/core/browser/signin_manager.h"

#include "components/user_prefs/user_prefs.h"

#include "content/public/browser/browser_thread.h"

@@ -833,8 +832,8 @@ void AppListViewDelegate::OnTemplateURLServiceChanged() {

const TemplateURL* default_provider =

template_url_service->GetDefaultSearchProvider();

bool is_google =

- TemplateURLPrepopulateData::GetEngineType(

- *default_provider, template_url_service->search_terms_data()) ==

+ default_provider->GetEngineType(

+ template_url_service->search_terms_data()) ==

SEARCH_ENGINE_GOOGLE;

model_->SetSearchEngineIsGoogle(is_google);