components/ntp_tiles/popular_sites.cc - Issue 1983773002: Cache SearchEngineType of TemplateURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_tiles/popular_sites.cc

Issue 1983773002: Cache SearchEngineType of TemplateURL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-extracting-terms-from-template-url

Patch Set: Fix typo Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/start_page_service.cc ('k') | components/omnibox/browser/base_search_provider.cc » ('j') | components/search_engines/prepopulated_engines.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_tiles/popular_sites.cc

diff --git a/components/ntp_tiles/popular_sites.cc b/components/ntp_tiles/popular_sites.cc

index 2012fdbcbee91753ebba716521394cf9b048ac00..85d04ca590615314d9688a9265eb38222c555f69 100644

--- a/components/ntp_tiles/popular_sites.cc

+++ b/components/ntp_tiles/popular_sites.cc

@@ -26,7 +26,6 @@

#include "components/prefs/pref_service.h"

#include "components/safe_json/safe_json_parser.h"

#include "components/search_engines/search_engine_type.h"

-#include "components/search_engines/template_url_prepopulate_data.h"

#include "components/search_engines/template_url_service.h"

#include "components/variations/service/variations_service.h"

#include "net/base/load_flags.h"

@@ -65,8 +64,8 @@ std::string GetDefaultSearchEngineCountryCode(

// search engine is defined by policy.

if (default_provider) {

bool is_google_search_engine =

- TemplateURLPrepopulateData::GetEngineType(

- *default_provider, template_url_service->search_terms_data()) ==

+ default_provider->GetEngineType(

+ template_url_service->search_terms_data()) ==

SearchEngineType::SEARCH_ENGINE_GOOGLE;

if (is_google_search_engine) {