components/search_engines/template_url.h - Issue 1983773002: Cache SearchEngineType of TemplateURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_engines/template_url.h

Issue 1983773002: Cache SearchEngineType of TemplateURL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-extracting-terms-from-template-url

Patch Set: Move calculation to TemplateURLData Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/search_engines/search_engine_type.h ('k') | components/search_engines/template_url.cc » ('j') | components/search_engines/template_url_data.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/search_engines/template_url.h

diff --git a/components/search_engines/template_url.h b/components/search_engines/template_url.h

index 2acb146851887d0f8246dbf56c4b60071374d097..215511919a144ce6fa563bd5433f590393482c4d 100644

--- a/components/search_engines/template_url.h

+++ b/components/search_engines/template_url.h

@@ -644,6 +644,11 @@ class TemplateURL {

// OMNIBOX_API_EXTENSION.

std::string GetExtensionId() const;

+ // Returns the type of this search engine, or SEARCH_ENGINE_OTHER if no

+ // engines match.

+ SearchEngineType GetEngineType(

+ const SearchTermsData& search_terms_data) const;

// Use the alternate URLs and the search URL to match the provided |url|

// and extract |search_terms| from it. Returns false and an empty

// |search_terms| if no search terms can be matched. The order in which the