Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 1983743002: When defining custom elements, check that the argument is a constructor (Closed)

Created:
4 years, 7 months ago by dominicc (has gone to gerrit)
Modified:
4 years, 7 months ago
Reviewers:
domenic
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jochen (gone - plz use gerrit), rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When defining custom elements, check that the argument is a constructor BUG=594918 Committed: https://crrev.com/baf58e07fe7a17c3e8faff4b354b9901e62a5734 Cr-Commit-Position: refs/heads/master@{#394002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html View 2 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp View 1 chunk +6 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
dominicc (has gone to gerrit)
PTAL Kudos, jochen, for speedily implementing V8 Issue 4993--you rock.
4 years, 7 months ago (2016-05-16 04:19:08 UTC) #2
domenic
lgtm. Would have been ideal if this was on v8::Value instead of v8::Object so that ...
4 years, 7 months ago (2016-05-16 18:07:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983743002/1
4 years, 7 months ago (2016-05-17 01:07:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 01:11:59 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 01:13:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/baf58e07fe7a17c3e8faff4b354b9901e62a5734
Cr-Commit-Position: refs/heads/master@{#394002}

Powered by Google App Engine
This is Rietveld 408576698