Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1983683003: Remove some c_str() calls from StringCs in xfa docs. (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove some c_str() calls from StringCs in xfa docs. Avoids the risk of possibly getting a non-null terminated buffer if the StringC happened to be created by Mid(), etc. Doesn't seem to happen in practice. Committed: https://pdfium.googlesource.com/pdfium/+/3f80c864d5318d4d80ac811d42c92d8f63e0b5ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -128 lines) Patch
M fpdfsdk/fpdfxfa/fpdfxfa_app.cpp View 4 chunks +28 lines, -32 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp View 3 chunks +10 lines, -11 lines 0 comments Download
M fpdfsdk/fpdfxfa/include/fpdfxfa_app.h View 1 chunk +15 lines, -16 lines 0 comments Download
M fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdocview.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_fffield.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_fftext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fftextedit.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidgetacc.cpp View 6 chunks +12 lines, -16 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 3 chunks +9 lines, -10 lines 0 comments Download
M xfa/fxfa/include/fxfa.h View 5 chunks +27 lines, -22 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp View 5 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Tom Sepez
Lei, for review.
4 years, 7 months ago (2016-05-16 17:46:11 UTC) #3
Tom Sepez
On 2016/05/16 17:46:11, Tom Sepez wrote: > Lei, for review. Or Dan, if he gets ...
4 years, 7 months ago (2016-05-16 18:21:44 UTC) #5
dsinclair
lgtm
4 years, 7 months ago (2016-05-16 18:27:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983683003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983683003/1
4 years, 7 months ago (2016-05-16 18:28:46 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 19:03:27 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/3f80c864d5318d4d80ac811d42c92d8f63e0...

Powered by Google App Engine
This is Rietveld 408576698