Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19836002: Blink roll 154563:154580 (Closed)

Created:
7 years, 5 months ago by eseidel
Modified:
7 years, 5 months ago
Reviewers:
gavinp
CC:
chromium-reviews, gavinp
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : need to add a landmine #

Total comments: 2

Patch Set 3 : review comment #

Total comments: 1

Patch Set 4 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/landmines.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
eseidel
This roll was created by the Blink AutoRollBot. http://www.chromium.org/blink/blinkrollbot
7 years, 5 months ago (2013-07-19 18:26:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/19836002/1
7 years, 5 months ago (2013-07-19 18:27:41 UTC) #2
gavinp
https://chromiumcodereview.appspot.com/19836002/diff/21001/build/landmines.py File build/landmines.py (right): https://chromiumcodereview.appspot.com/19836002/diff/21001/build/landmines.py#newcode160 build/landmines.py:160: Put your add up above this blank line. https://chromiumcodereview.appspot.com/19836002/diff/21001/build/landmines.py#newcode162 ...
7 years, 5 months ago (2013-07-19 20:29:33 UTC) #3
eseidel
No longer marked for the CQ. Closing, will open a new roll.
7 years, 5 months ago (2013-07-19 20:32:11 UTC) #4
gavinp
LGTM, but it's prolly best to fix the grammar in the landmine before landing. https://chromiumcodereview.appspot.com/19836002/diff/25001/build/landmines.py ...
7 years, 5 months ago (2013-07-19 20:32:30 UTC) #5
cbiesinger
7 years, 5 months ago (2013-07-19 20:34:50 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 manually as r212639 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698