Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: BUILD.gn

Issue 1983593002: [builtins] Move EncodeURI from runtime to builtins. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index b6a04156055db22e9085b4975643d5869df8e071..7702309320a4174cafd57d59b491814445a2082a 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -320,7 +320,7 @@ config("toolchain") {
template("v8_source_set") {
source_set(target_name) {
- forward_variables_from(invoker, "*", ["configs"])
+ forward_variables_from(invoker, "*", [ "configs" ])
configs += invoker.configs
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
@@ -667,9 +667,7 @@ v8_source_set("v8_nosnapshot") {
"src/snapshot/snapshot-empty.cc",
]
- configs = [
- ":internal_config",
- ]
+ configs = [ ":internal_config" ]
}
v8_source_set("v8_snapshot") {
@@ -701,9 +699,7 @@ v8_source_set("v8_snapshot") {
"$target_gen_dir/snapshot.cc",
]
- configs = [
- ":internal_config",
- ]
+ configs = [ ":internal_config" ]
}
if (v8_use_external_startup_data) {
@@ -727,9 +723,7 @@ if (v8_use_external_startup_data) {
"src/snapshot/snapshot-external.cc",
]
- configs = [
- ":internal_config",
- ]
+ configs = [ ":internal_config" ]
}
}
@@ -1474,6 +1468,8 @@ v8_source_set("v8_base") {
"src/unicode-inl.h",
"src/unicode.cc",
"src/unicode.h",
+ "src/uri.cc",
+ "src/uri.h",
"src/utils-inl.h",
"src/utils.cc",
"src/utils.h",
@@ -1820,9 +1816,7 @@ v8_source_set("v8_base") {
]
}
- configs = [
- ":internal_config",
- ]
+ configs = [ ":internal_config" ]
defines = []
deps = [
@@ -1915,9 +1909,7 @@ v8_source_set("v8_libbase") {
"src/base/utils/random-number-generator.h",
]
- configs = [
- ":internal_config_base",
- ]
+ configs = [ ":internal_config_base" ]
defines = []
@@ -1977,13 +1969,9 @@ v8_source_set("v8_libplatform") {
"src/libplatform/worker-thread.h",
]
- configs = [
- ":internal_config_base",
- ]
+ configs = [ ":internal_config_base" ]
- public_configs = [
- ":libplatform_config"
- ]
+ public_configs = [ ":libplatform_config" ]
deps = [
":v8_libbase",
@@ -1998,9 +1986,7 @@ v8_source_set("fuzzer_support") {
"test/fuzzer/fuzzer-support.h",
]
- configs = [
- ":internal_config_base",
- ]
+ configs = [ ":internal_config_base" ]
deps = [
snapshot_target,
@@ -2156,9 +2142,7 @@ v8_source_set("json_fuzzer") {
":fuzzer_support",
]
- configs = [
- ":internal_config",
- ]
+ configs = [ ":internal_config" ]
}
v8_source_set("parser_fuzzer") {
@@ -2170,9 +2154,7 @@ v8_source_set("parser_fuzzer") {
":fuzzer_support",
]
- configs = [
- ":internal_config",
- ]
+ configs = [ ":internal_config" ]
}
v8_source_set("regexp_fuzzer") {
@@ -2184,9 +2166,7 @@ v8_source_set("regexp_fuzzer") {
":fuzzer_support",
]
- configs = [
- ":internal_config",
- ]
+ configs = [ ":internal_config" ]
}
v8_source_set("wasm_fuzzer") {
@@ -2198,9 +2178,7 @@ v8_source_set("wasm_fuzzer") {
":fuzzer_support",
]
- configs = [
- ":internal_config",
- ]
+ configs = [ ":internal_config" ]
}
v8_source_set("wasm_asmjs_fuzzer") {
@@ -2212,7 +2190,5 @@ v8_source_set("wasm_asmjs_fuzzer") {
":fuzzer_support",
]
- configs = [
- ":internal_config",
- ]
+ configs = [ ":internal_config" ]
}
« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698