[builtins] Move EncodeURI from runtime to builtins.

[builtins] Move EncodeURI from runtime to builtins.

Repackage encodeURI and encodeURIComponent as builtin functions
and install them in the bootstrapper.

Crude benchmark on 351 encodeURI and encodeURIComponent tests averaged
over five runs:

* builtin functions
real	0m8.01s
user	0m18.00s
sys	0m7.37s

* JS functions calling into the runtime e.g., for %NewString
real	0m8.44s
user	0m19.52s
sys	0m7.49s

By running:
$ time tools/run-tests.py   --arch=x64 --mode=Release --buildbot
mjsunit/uri test262/built-ins/encodeURI*
>>> Running tests for x64.Release

BUG=v8:4912
R=yangguo@chromium.org

Committed: https://crrev.com/c60cb90c4f60cdfc80422044ead64e431dbe7ce9
Cr-Commit-Position: refs/heads/master@{#36273}

[Franzi, 2016-05-16 09:32:31]

Description was changed from

==========
[builtins] Move EncodeURI from runtime to builtins.

Repackage encodeURI and encodeURIComponent as builtin functions
and install them in the bootstrapper.

Crude benchmark on 351 encodeURI and encodeURIComponent tests is as follows:

* builtin function
real	0m15.664s
user	0m46.941s
sys	0m8.535s

* JS function calling into the runtime e.g., for %NewString
real	0m19.224s
user	0m58.505s
sys	0m9.148s

By running:
$ time tools/run-tests.py   --arch=x64 --mode=OptDebug --buildbot
mjsunit/uri test262/built-ins/encodeURI*
>>> Running tests for x64.OptDebug

BUG=v8:4912
R=yangguo@chromium.org
==========

to

==========
[builtins] Move EncodeURI from runtime to builtins.

Repackage encodeURI and encodeURIComponent as builtin functions
and install them in the bootstrapper.

Crude benchmark on 351 encodeURI and encodeURIComponent tests is as follows:

* builtin function
real	0m15.664s
user	0m46.941s
sys	0m8.535s

* JS function calling into the runtime e.g., for %NewString
real	0m19.224s
user	0m58.505s
sys	0m9.148s

By running:
$ time tools/run-tests.py   --arch=x64 --mode=OptDebug --buildbot
mjsunit/uri test262/built-ins/encodeURI*
>>> Running tests for x64.OptDebug

BUG=v8:4912
R=yangguo@chromium.org
==========

[Franzi, 2016-05-16 09:32:31]

franzih@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Franzi, 2016-05-16 12:28:05]

Description was changed from

==========
[builtins] Move EncodeURI from runtime to builtins.

Repackage encodeURI and encodeURIComponent as builtin functions
and install them in the bootstrapper.

Crude benchmark on 351 encodeURI and encodeURIComponent tests is as follows:

* builtin function
real	0m15.664s
user	0m46.941s
sys	0m8.535s

* JS function calling into the runtime e.g., for %NewString
real	0m19.224s
user	0m58.505s
sys	0m9.148s

By running:
$ time tools/run-tests.py   --arch=x64 --mode=OptDebug --buildbot
mjsunit/uri test262/built-ins/encodeURI*
>>> Running tests for x64.OptDebug

BUG=v8:4912
R=yangguo@chromium.org
==========

to

==========
[builtins] Move EncodeURI from runtime to builtins.

Repackage encodeURI and encodeURIComponent as builtin functions
and install them in the bootstrapper.

Crude benchmark on 351 encodeURI and encodeURIComponent tests averaged
over five runs:

* builtin functions
real	0m8.01s
user	0m18.00s
sys	0m7.37s

* JS functions calling into the runtime e.g., for %NewString
real	0m8.44s
user	0m19.52s
sys	0m7.49s

By running:
$ time tools/run-tests.py   --arch=x64 --mode=Release --buildbot
mjsunit/uri test262/built-ins/encodeURI*
>>> Running tests for x64.Release

BUG=v8:4912
R=yangguo@chromium.org
==========

[Yang, 2016-05-17 05:15:38]

https://codereview.chromium.org/1983593002/diff/40001/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/1983593002/diff/40001/src/builtins.cc#newcode...
src/builtins.cc:2238: return EncodeUri(isolate, uri, true);
builtins.cc is already bloated from all sorts of things. Someone needs to split
up this file. But in the meantime, could you move EncodeUri into a separate file
into a static file? Thanks.

https://codereview.chromium.org/1983593002/diff/40001/src/contexts.h
File src/contexts.h (right):

https://codereview.chromium.org/1983593002/diff/40001/src/contexts.h#newcode107
src/contexts.h:107: V(GLOBAL_ENCODE_URI_COMPONENT_FUN_INDEX, JSFunction,        
             \
We don't need these two lines. We don't need to access these two functions in
the runtime.

[Franzi, 2016-05-17 10:25:31]

HI Yang, 

Could you have another look please. I moved the code out of builtins.cc into a
static class. Also extracted native_context()->global_object() into a variable.

DecodeURI() and DecodeURIComponent() still need to be rewritten in C++ code.
I'll move escape/unescape from runtime-uri.cc into the same class and see how
much duplicated code I can eliminate. 

Thanks, 

Franzi

https://codereview.chromium.org/1983593002/diff/40001/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/1983593002/diff/40001/src/builtins.cc#newcode...
src/builtins.cc:2238: return EncodeUri(isolate, uri, true);
On 2016/05/17 05:15:38, Yang wrote:
> builtins.cc is already bloated from all sorts of things. Someone needs to
split
> up this file. But in the meantime, could you move EncodeUri into a separate
file
> into a static file? Thanks.

Moved into src/uri.h

https://codereview.chromium.org/1983593002/diff/40001/src/contexts.h
File src/contexts.h (right):

https://codereview.chromium.org/1983593002/diff/40001/src/contexts.h#newcode107
src/contexts.h:107: V(GLOBAL_ENCODE_URI_COMPONENT_FUN_INDEX, JSFunction,        
             \
On 2016/05/17 05:15:38, Yang wrote:
> We don't need these two lines. We don't need to access these two functions in
> the runtime.

Removed. Not installing them in native context.

[Yang, 2016-05-17 10:40:10]

lgtm

[Franzi, 2016-05-17 10:52:33]

The CQ bit was checked by franzih@chromium.org

[commit-bot: I haz the power, 2016-05-17 10:52:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1983593002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1983593002/60001

[commit-bot: I haz the power, 2016-05-17 10:54:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-17 10:56:38]

Description was changed from

==========
[builtins] Move EncodeURI from runtime to builtins.

Repackage encodeURI and encodeURIComponent as builtin functions
and install them in the bootstrapper.

Crude benchmark on 351 encodeURI and encodeURIComponent tests averaged
over five runs:

* builtin functions
real	0m8.01s
user	0m18.00s
sys	0m7.37s

* JS functions calling into the runtime e.g., for %NewString
real	0m8.44s
user	0m19.52s
sys	0m7.49s

By running:
$ time tools/run-tests.py   --arch=x64 --mode=Release --buildbot
mjsunit/uri test262/built-ins/encodeURI*
>>> Running tests for x64.Release

BUG=v8:4912
R=yangguo@chromium.org
==========

to

==========
[builtins] Move EncodeURI from runtime to builtins.

Repackage encodeURI and encodeURIComponent as builtin functions
and install them in the bootstrapper.

Crude benchmark on 351 encodeURI and encodeURIComponent tests averaged
over five runs:

* builtin functions
real	0m8.01s
user	0m18.00s
sys	0m7.37s

* JS functions calling into the runtime e.g., for %NewString
real	0m8.44s
user	0m19.52s
sys	0m7.49s

By running:
$ time tools/run-tests.py   --arch=x64 --mode=Release --buildbot
mjsunit/uri test262/built-ins/encodeURI*
>>> Running tests for x64.Release

BUG=v8:4912
R=yangguo@chromium.org

Committed: https://crrev.com/c60cb90c4f60cdfc80422044ead64e431dbe7ce9
Cr-Commit-Position: refs/heads/master@{#36273}
==========

[commit-bot: I haz the power, 2016-05-17 10:56:39]

Patchset 4 (id:??) landed as
https://crrev.com/c60cb90c4f60cdfc80422044ead64e431dbe7ce9
Cr-Commit-Position: refs/heads/master@{#36273}