Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 198353003: Land Recent QUIC Changes (Closed)

Created:
6 years, 9 months ago by ramant (doing other things)
Modified:
6 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke
Visibility:
Public.

Description

Land Recent QUIC Changes Add varz to track QUIC packets and bytes sent by transmission type. Not flag protected. Merge internal change: 63037893 + Updated QuicConnectionLogger to log TransmissionType. + Used connection_id instead of GUID in the comments. + Moved QUIC_SESSION_PACKET_SENT and QUIC_SESSION_PACKET_RETRANSMITTED to match the log messages description. https://codereview.chromium.org/196053008/ Killing off QUIC v14, which was never actually used. Merge internal change: 63025464 https://codereview.chromium.org/198523002/ Adds a varz variable to track the fraction of times we end up in cubic mode during congestion control. Merge internal change: 62977386 https://codereview.chromium.org/198303004/ Export QUIC response retransmit packet and byte counts via faster stats. Computation is done on a stream basis and ignores retransmitted control packets. Merge internal change: 62911712 https://codereview.chromium.org/197473012/ Avoiding a double disconnect scenario, and DFATALs on server. Merge internal change: 62767600 https://codereview.chromium.org/198263003/ Making GOAWAY advisory for SPDY-over-QUIC. Sending GOAWAYs on new connections when the server enters lame duck. Making sure we only send a GOAWAY once on a given connection. Merge internal change: 62700562 https://codereview.chromium.org/196343008/ R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256932

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -139 lines) Patch
M net/base/net_log_event_type_list.h View 3 chunks +8 lines, -5 lines 0 comments Download
M net/quic/congestion_control/cubic.cc View 1 chunk +11 lines, -13 lines 0 comments Download
M net/quic/congestion_control/cubic_test.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M net/quic/quic_ack_notifier.h View 3 chunks +32 lines, -10 lines 0 comments Download
M net/quic/quic_ack_notifier.cc View 4 chunks +39 lines, -14 lines 0 comments Download
M net/quic/quic_ack_notifier_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_ack_notifier_test.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M net/quic/quic_connection.h View 1 chunk +15 lines, -14 lines 0 comments Download
M net/quic/quic_connection.cc View 3 chunks +12 lines, -5 lines 0 comments Download
M net/quic/quic_connection_logger.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 2 chunks +4 lines, -1 line 0 comments Download
M net/quic/quic_connection_stats.h View 1 chunk +2 lines, -4 lines 0 comments Download
M net/quic/quic_connection_stats.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_connection_test.cc View 8 chunks +9 lines, -8 lines 0 comments Download
M net/quic/quic_framer.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M net/quic/quic_framer_test.cc View 11 chunks +18 lines, -18 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_packet_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_protocol.h View 2 chunks +0 lines, -2 lines 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M net/quic/quic_session.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M net/quic/quic_session_test.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M net/quic/quic_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +4 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
ramant (doing other things)
6 years, 9 months ago (2014-03-13 03:26:07 UTC) #1
Ryan Hamilton
lgtm
6 years, 9 months ago (2014-03-13 15:27:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/198353003/1
6 years, 9 months ago (2014-03-13 15:27:42 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 15:36:43 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
6 years, 9 months ago (2014-03-13 15:36:44 UTC) #5
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 9 months ago (2014-03-13 15:58:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/198353003/1
6 years, 9 months ago (2014-03-13 15:59:17 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 16:07:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
6 years, 9 months ago (2014-03-13 16:07:39 UTC) #9
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 9 months ago (2014-03-13 17:31:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/198353003/1
6 years, 9 months ago (2014-03-13 17:32:44 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 17:51:51 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-13 17:51:52 UTC) #13
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 9 months ago (2014-03-13 17:55:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/198353003/1
6 years, 9 months ago (2014-03-13 17:56:04 UTC) #15
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 21:23:57 UTC) #16
Message was sent while issue was closed.
Change committed as 256932

Powered by Google App Engine
This is Rietveld 408576698