Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1983503002: Enable gn check of some //media files (Closed)

Created:
4 years, 7 months ago by jrummell
Modified:
4 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable gn check of some //media files Now that some subdirectories are clean, prevent regressions. BUG=599578 Committed: https://crrev.com/370e8f900c9d7379319a8f04b6c6bad7eae86bd2 Cr-Commit-Position: refs/heads/master@{#397486}

Patch Set 1 #

Patch Set 2 : remove test #

Patch Set 3 : add base + mojo #

Patch Set 4 : remove base #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M .gn View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
jrummell
PTAL. Enabling gn check on 1/2 of the media files. Running trybots to see if ...
4 years, 7 months ago (2016-05-13 23:39:48 UTC) #2
jrummell
brettw@: Looks like I've finally fixed enough errors in the selected //media directories to keep ...
4 years, 6 months ago (2016-05-27 19:57:26 UTC) #3
brettw
lgtm
4 years, 6 months ago (2016-05-31 19:24:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983503002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983503002/60001
4 years, 6 months ago (2016-06-02 01:19:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/80401)
4 years, 6 months ago (2016-06-02 02:08:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983503002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983503002/60001
4 years, 6 months ago (2016-06-02 02:15:38 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/196976)
4 years, 6 months ago (2016-06-02 02:33:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983503002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983503002/60001
4 years, 6 months ago (2016-06-02 16:55:08 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-02 19:16:43 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 19:19:10 UTC) #17
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/370e8f900c9d7379319a8f04b6c6bad7eae86bd2
Cr-Commit-Position: refs/heads/master@{#397486}

Powered by Google App Engine
This is Rietveld 408576698