Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1480)

Issue 1983443002: mac/gn: Make a bunch of targets build in release component builds. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
Robert Sesek, brettw
CC:
chromium-reviews, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, tfarina, piman+watch_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac/gn: Make a bunch of targets build in release component builds. Namely, fixes rlz_unittests, macviews_interactive_ui_tests, rlz_id, accelerated_widget_mac_unittests, gl_unittests, gl_tests BUG=431177 TBR=brettw CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/85138c4410c718ccf4eed1f48c42c8edd7cac1e8 Cr-Commit-Position: refs/heads/master@{#393680}

Patch Set 1 #

Patch Set 2 : format #

Total comments: 1

Patch Set 3 : skip cast for now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M device/serial/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M gpu/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M rlz/BUILD.gn View 1 1 chunk +7 lines, -0 lines 0 comments Download
M ui/accelerated_widget_mac/BUILD.gn View 1 1 chunk +4 lines, -1 line 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Nico
4 years, 7 months ago (2016-05-13 20:52:34 UTC) #3
Robert Sesek
lgtm
4 years, 7 months ago (2016-05-13 20:58:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983443002/20001
4 years, 7 months ago (2016-05-13 21:00:58 UTC) #6
Nico
tbr brettw for global owners (change is boring, and rsesek lgtm'd it)
4 years, 7 months ago (2016-05-13 21:02:42 UTC) #9
Nico
https://codereview.chromium.org/1983443002/diff/20001/media/cast/BUILD.gn File media/cast/BUILD.gn (right): https://codereview.chromium.org/1983443002/diff/20001/media/cast/BUILD.gn#newcode546 media/cast/BUILD.gn:546: group("cast_sender") { actually, i think this change is wrong
4 years, 7 months ago (2016-05-13 21:03:47 UTC) #10
brettw
lgtm
4 years, 7 months ago (2016-05-13 21:13:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983443002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983443002/40001
4 years, 7 months ago (2016-05-13 21:43:28 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-13 23:16:55 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 23:18:09 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/85138c4410c718ccf4eed1f48c42c8edd7cac1e8
Cr-Commit-Position: refs/heads/master@{#393680}

Powered by Google App Engine
This is Rietveld 408576698