Add timeout for SAML webcam logins

chrome/browser/resources/chromeos/login/screen_gaia_signin.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Oobe signin screen implementation.
  */
 
 login.createScreen('GaiaSigninScreen', 'gaia-signin', function() {
   // GAIA animation guard timer. Started when GAIA page is loaded
   // (Authenticator 'ready' event) and is intended to guard against edge cases
   // when 'showView' message is not generated/received.
   /** @const */ var GAIA_ANIMATION_GUARD_MILLISEC = 300;
 
   // Maximum Gaia loading time in seconds.
   /** @const */ var MAX_GAIA_LOADING_TIME_SEC = 60;
 
   // The help topic regarding user not being in the whitelist.
   /** @const */ var HELP_CANT_ACCESS_ACCOUNT = 188036;
 
   // Amount of time the user has to be idle for before showing the online login
   // page.
   /** @const */ var IDLE_TIME_UNTIL_EXIT_OFFLINE_IN_MILLISECONDS = 180 * 1000;
 
   // Approximate amount of time between checks to see if we should go to the
   // online login page when we're in the offline login page and the device is
   // online.
   /** @const */ var IDLE_TIME_CHECK_FREQUENCY = 5 * 1000;
 
+  // Amount of time allowed for video based SAML logins, to prevent a site
+  // from keeping the camera on indefinitely.  This is a hard deadline and
+  // it will not be extended by user activity.
+  /** @const */ var MAX_VIDEO_LOGIN_TIME_SEC = 60;
+
   /**
    * The modes this screen can be in.
    * @enum {integer}
    */
   var ScreenMode = {
     DEFAULT: 0,           // Default GAIA login flow.
     OFFLINE: 1,           // GAIA offline login.
     SAML_INTERSTITIAL: 2  // Interstitial page before SAML redirection.
   };
 
@@ skipping 35 matching lines @@
 
     /**
      * Timer id of a guard timer that is fired in case 'showView' message
      * is not received from GAIA.
      * @type {number}
      * @private
      */
     loadAnimationGuardTimer_: undefined,
 
     /**
+     * Timer id of the video login timer.
+     * @type {number}
+     * @private
+     */
+    videoTimer_: undefined,
+
+    /**
      * Whether we've processed 'showView' message - either from GAIA or from
      * guard timer.
      * @type {boolean}
      * @private
      */
     showViewProcessed_: false,
 
     /**
      * Whether we've processed 'authCompleted' message.
      * @type {boolean}
@@ skipping 533 matching lines @@
      */
     onAuthDomainChange_: function() {
       this.updateSamlNotice_();
     },
 
     /**
      * Invoked when the videoEnabled property is changed on the GAIA host.
      */
     onVideoEnabledChange_: function() {
       this.updateSamlNotice_();
+      if (this.gaiaAuthHost_.videoEnabled && this.videoTimer_ === undefined) {
+        this.videoTimer_ = setTimeout(this.cancel.bind(this),

[Kevin Cernekee, 2016/05/13 20:53:54]

This timer needs to be canceled if the user clicks the "X" button or if login
succeeds.

I can't test the successful login flow right now.  Do you have any thoughts on
where in the code the "cancel timer" logic belongs?  Is onAuthFlowChange a good
candidate?

I've also noticed that manually canceling + restarting the flow does not reset
the videoEnabled flag, but maybe that should be reset elsewhere.

FWIW I am testing all of this by clicking "Add person" on a Chromebook that is
already owned by a test account.  Other flows that probably need to be handled
include:

 - Enterprise login with no default user
 - Enterprise login with "click here for video login" enabled
 - OOBE enrollment - do we care about this?

+            MAX_VIDEO_LOGIN_TIME_SEC * 1000);
+      }
     },
 
     /**
      * Invoked when the authFlow property is changed on the GAIA host.
      */
     onAuthFlowChange_: function() {
       var isSAML = this.isSAML();
 
       this.classList.toggle('full-width', isSAML);
       $('saml-notice-container').hidden = !isSAML;
@@ skipping 362 matching lines @@
       this.classList.toggle('whitelist-error', show);
       this.loading = !show;
 
       if (!show)
         Oobe.showSigninUI();
 
       this.updateControlsState();
     }
   };
 });