third_party/WebKit/LayoutTests/inspector/console/console-xpath.html - Issue 1983423002: [DevTools] Move CommandLineAPI querySelector and querySelectorAll to native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/console/console-xpath.html

Issue 1983423002: [DevTools] Move CommandLineAPI querySelector and querySelectorAll to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pass-bind-remote-object

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/inspector/console/console-xpath-expected.txt » ('j') | third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/console/console-xpath.html

diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-xpath.html b/third_party/WebKit/LayoutTests/inspector/console/console-xpath.html

index 8ec0d777f61d0c0c0efb1ff7adf0ffcdf5fb4755..00dff30cb1ccbadb7842e40eeda21f3b56d4696c 100644

--- a/third_party/WebKit/LayoutTests/inspector/console/console-xpath.html

+++ b/third_party/WebKit/LayoutTests/inspector/console/console-xpath.html

@@ -6,7 +6,7 @@

function test()

{

- InspectorTest.addSniffer(WebInspector.ConsoleViewMessage.prototype, "_formattedParameterAsNodeForTest", formattedParameter);

+ InspectorTest.addSniffer(WebInspector.ConsoleViewMessage.prototype, "_formattedParameterAsNodeForTest", formattedParameter, true);

InspectorTest.addConsoleViewSniffer(messageSniffer, true);

InspectorTest.evaluateInConsole("$x('42')"); // number

@@ -14,6 +14,8 @@ function test()

InspectorTest.evaluateInConsole("$x('not(42)')"); // boolean

InspectorTest.evaluateInConsole("$x('/html/body/p').length"); // node iterator

InspectorTest.evaluateInConsole("$x('//a/@href')[0]"); // href, should not throw

+ InspectorTest.evaluateInConsole("$x('./a/@href', document.body)[0]"); // relative to document.body selector

+ InspectorTest.evaluateInConsole("$x('./a@href', document.body)"); // incorrect selector, shouldn't crash

InspectorTest.evaluateInPage("console.log('complete')"); // node iterator

var completeMessageReceived = false;

@@ -25,16 +27,16 @@ function test()

}

- var parameterFormatted = false;

+ var waitForParameteres = 2;

function formattedParameter()

{

- parameterFormatted = true;

+ waitForParameteres--;

maybeCompleteTest();

}

function maybeCompleteTest()

{

- if (parameterFormatted && completeMessageReceived) {

+ if (!waitForParameteres && completeMessageReceived) {

InspectorTest.dumpConsoleMessages();

InspectorTest.completeTest();

}

@@ -43,8 +45,8 @@ function test()

</script>

</head>

-<a href="http://chromium.org"></a>

+<a href="http://chromium.org"></a>

<p>

Tests $x for iterator and non-iterator types.

</p>