third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp - Issue 1983423002: [DevTools] Move CommandLineAPI querySelector and querySelectorAll to native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 1983423002: [DevTools] Move CommandLineAPI querySelector and querySelectorAll to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pass-bind-remote-object

Patch Set: rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-xpath-expected.txt ('k') | third_party/WebKit/Source/core/inspector/MainThreadDebugger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

index 57126843c894a2eb5f2f3ba1156e3ceeb27f30c8..86bf76ca4f5193c0f0c70668a64071267421892a 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

@@ -57,6 +57,7 @@

#include "core/html/HTMLCollection.h"

#include "core/html/HTMLDocument.h"

#include "core/inspector/InspectorInstrumentation.h"

+#include "core/inspector/MainThreadDebugger.h"

#include "core/loader/FrameLoadRequest.h"

#include "core/loader/FrameLoader.h"

#include "core/loader/FrameLoaderClient.h"

@@ -251,7 +252,7 @@ static bool namedPropertyFromDebuggerScopeExtension(v8::Local<v8::Name> name, co

return false;

bool isGetter = V8Debugger::isCommandLineAPIGetter(nameString);

- bool isMethod = !isGetter && V8Debugger::isCommandLineAPIMethod(nameString);

+ bool isMethod = !isGetter && MainThreadDebugger::isCommandLineAPIMethod(nameString);

if (!isGetter && !isMethod)

return false;