third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp - Issue 1983423002: [DevTools] Move CommandLineAPI querySelector and querySelectorAll to native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

Issue 1983423002: [DevTools] Move CommandLineAPI querySelector and querySelectorAll to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pass-bind-remote-object

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h » ('j') | third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

index 0eccb8287798b892b54c0b526a988ef069b228e5..dd4b4cedbb68822cfc3302eb32b6df322fba32ae 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

@@ -681,6 +681,8 @@ v8::Local<v8::Object> V8Console::createCommandLineAPI(InspectedContext* inspecte

createBoundFunctionProperty(context, commandLineAPI, "$3", V8Console::inspectedObject3);

createBoundFunctionProperty(context, commandLineAPI, "$4", V8Console::inspectedObject4);

+ inspectedContext->debugger()->client()->willInstallCommandLineAPI(context, commandLineAPI);

commandLineAPI->SetPrivate(context, inspectedContextPrivateKey(isolate), v8::External::New(isolate, inspectedContext));

return commandLineAPI;

}