Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/WebKit/LayoutTests/intersection-observer/containing-block.html

Issue 1983383002: Convert IntersectionObserver tests to use testRunner.runIdleTasks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/intersection-observer/containing-block.html
diff --git a/third_party/WebKit/LayoutTests/intersection-observer/containing-block.html b/third_party/WebKit/LayoutTests/intersection-observer/containing-block.html
index 819ec5fabb56d591c05bc4c601b16078449fc36a..d5dba329354891b56dde16f0b6f08b84ba594338 100644
--- a/third_party/WebKit/LayoutTests/intersection-observer/containing-block.html
+++ b/third_party/WebKit/LayoutTests/intersection-observer/containing-block.html
@@ -25,7 +25,7 @@ var target = document.getElementById("target");
var entries = [];
var observer = new IntersectionObserver(
- changes => { entries = entries.concat(changes) },
+ changes => { entries.push(...changes) },
{ root: root }
);
@@ -33,12 +33,10 @@ onload = function() {
observer.observe(target);
shouldBeEqualToNumber("entries.length", 0);
target.style.top = "10px";
- // See README for explanation of double RAF.
- requestAnimationFrame(() => { requestAnimationFrame(step1) });
+ waitForNotification(step1);
};
function step1() {
- entries = entries.concat(observer.takeRecords());
shouldBeEqualToNumber("entries.length", 1);
if (entries.length > 0) {
shouldBeEqualToNumber("entries[0].boundingClientRect.left", 58);
@@ -56,11 +54,10 @@ function step1() {
shouldEvaluateToSameObject("entries[0].target", target);
}
target.style.top = "250px";
- requestAnimationFrame(step2);
+ waitForNotification(step2);
}
function step2() {
- entries = entries.concat(observer.takeRecords());
shouldBeEqualToNumber("entries.length", 2);
if (entries.length > 1) {
shouldBeEqualToNumber("entries[1].boundingClientRect.left", 58);
@@ -79,18 +76,16 @@ function step2() {
}
root.style.position = "static";
target.style.top = "10px";
- requestAnimationFrame(step3);
+ waitForNotification(step3);
}
function step3() {
- entries = entries.concat(observer.takeRecords());
shouldBeEqualToNumber("entries.length", 2);
target.style.top = "250px";
- requestAnimationFrame(step4);
+ waitForNotification(step4);
}
function step4() {
- entries = entries.concat(observer.takeRecords());
shouldBeEqualToNumber("entries.length", 2);
finishJSTest();
}

Powered by Google App Engine
This is Rietveld 408576698