Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java

Issue 1983353002: [Android] Coordinate Infobars and Snackbars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java
index 78c1a27907ed3b7de61e5725cc2bf89565b9bd03..6dc816df2755836cb439e54d00f0f1a75eba7b10 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java
@@ -4,10 +4,10 @@
package org.chromium.chrome.browser.snackbar;
+import android.app.Activity;
import android.os.Handler;
import android.view.View;
import android.view.View.OnClickListener;
-import android.view.ViewGroup;
import org.chromium.base.VisibleForTesting;
import org.chromium.base.metrics.RecordHistogram;
@@ -61,7 +61,7 @@ public class SnackbarManager implements OnClickListener {
private static int sSnackbarDurationMs = DEFAULT_SNACKBAR_DURATION_MS;
private static int sAccessibilitySnackbarDurationMs = ACCESSIBILITY_MODE_SNACKBAR_DURATION_MS;
- private ViewGroup mParentView;
+ private Activity mActivity;
private SnackbarView mView;
private final Handler mUIThreadHandler;
private SnackbarCollection mSnackbars = new SnackbarCollection();
@@ -79,8 +79,8 @@ public class SnackbarManager implements OnClickListener {
* Constructs a SnackbarManager to show snackbars in the given window.
* @param rootView The main view (e.g. android.R.id.content) of the embedding activity.
*/
- public SnackbarManager(ViewGroup rootView) {
- mParentView = rootView;
+ public SnackbarManager(Activity activity) {
+ mActivity = activity;
mUIThreadHandler = new Handler();
}
@@ -168,7 +168,7 @@ public class SnackbarManager implements OnClickListener {
} else {
boolean viewChanged = true;
if (mView == null) {
- mView = new SnackbarView(mParentView, this, currentSnackbar);
+ mView = new SnackbarView(mActivity, this, currentSnackbar);
mView.show();
} else {
viewChanged = mView.update(currentSnackbar);
@@ -187,7 +187,7 @@ public class SnackbarManager implements OnClickListener {
private int getDuration(Snackbar snackbar) {
int durationMs = snackbar.getDuration();
if (durationMs == 0) {
- durationMs = DeviceClassManager.isAccessibilityModeEnabled(mParentView.getContext())
+ durationMs = DeviceClassManager.isAccessibilityModeEnabled(mActivity)
? sAccessibilitySnackbarDurationMs : sSnackbarDurationMs;
}
return durationMs;

Powered by Google App Engine
This is Rietveld 408576698