Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1983343002: Makes mus::Window and mash::wm::WmWindowMus notify existing observers only (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, rjkroege, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes mus::Window and mash::wm::WmWindowMus notify existing observers only This matches what we do in aura, and is causing problems if I do otherwise. BUG=603369 TEST=none R=jamescook@chromium.org Committed: https://crrev.com/5ad2a6e51685cab37866676afcec388c066f30fa Cr-Commit-Position: refs/heads/master@{#394283}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M components/mus/public/cpp/lib/window.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mash/wm/bridge/wm_window_mus.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 7 months ago (2016-05-17 22:47:13 UTC) #1
James Cook
lgtm
4 years, 7 months ago (2016-05-17 23:20:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983343002/1
4 years, 7 months ago (2016-05-17 23:28:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 00:29:50 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 00:31:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ad2a6e51685cab37866676afcec388c066f30fa
Cr-Commit-Position: refs/heads/master@{#394283}

Powered by Google App Engine
This is Rietveld 408576698