Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 198333004: Move ui.gyp into ui/base/ directory. (Closed)

Created:
6 years, 9 months ago by tfarina
Modified:
6 years, 9 months ago
CC:
chromium-reviews, sadrul, chromoting-reviews_chromium.org, rjkroege, sievers+watch_chromium.org, ben+aura_chromium.org, ben+mojo_chromium.org, extensions-reviews_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, cc-bugs_chromium.org, ozone-reviews_chromium.org, feature-media-reviews_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, darin (slow to review), chrome-apps-syd-reviews_chromium.org, Ian Vollick, tfarina, Aaron Boodman, danakj+watch_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Move ui.gyp into ui/base/ directory. This follows the rule we setup for //ui which states that each subdir should be its own component with its own gyp file that lives in its subdir. The 'ui' target was renamed to ui_base to match the convention. BUG=299841 TEST=gyp files. TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256788

Patch Set 1 #

Patch Set 2 : REBASED #

Unified diffs Side-by-side diffs Delta from patch set Stats (+513 lines, -1146 lines) Patch
M android_webview/android_webview_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/webview_native.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/ash.gyp View 1 7 chunks +4 lines, -4 lines 0 comments Download
M build/all.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/libgtk2ui.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui_views.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 4 chunks +5 lines, -5 lines 0 comments Download
M components/autofill.gypi View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/components_tests.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M components/policy/policy_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/translate.gypi View 1 chunk +5 lines, -5 lines 0 comments Download
M components/user_prefs.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/web_contents_delegate_android.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_app.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_child.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_ppapi_plugin.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 8 chunks +17 lines, -17 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer_service.gypi View 1 chunk +5 lines, -5 lines 0 comments Download
M gpu/gles2_conform_support/gles2_conform_support.gyp View 1 chunk +3 lines, -3 lines 0 comments Download
M media/media.gyp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M printing/printing.gyp View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/remoting.gyp View 1 chunk +7 lines, -7 lines 0 comments Download
M remoting/remoting_test.gypi View 1 chunk +1 line, -1 line 0 comments Download
M tools/set_default_handler/set_default_handler.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/app_list/app_list.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/aura.gyp View 6 chunks +5 lines, -5 lines 0 comments Download
A + ui/base/ui_base.gyp View 8 chunks +395 lines, -395 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/keyboard/keyboard.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/message_center.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/native_theme/native_theme.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/ime/ime.gypi View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/shell_dialogs.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/snapshot/snapshot.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/surface/surface.gyp View 1 chunk +1 line, -1 line 0 comments Download
D ui/ui.gyp View 1 chunk +0 lines, -632 lines 0 comments Download
M ui/ui_unittests.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/webview/webview.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/linux_ui/linux_ui.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/views.gyp View 1 10 chunks +8 lines, -8 lines 0 comments Download
M webkit/child/webkit_child.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M webkit/common/webkit_common.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/delegate_execute.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
tfarina
TBRing...
6 years, 9 months ago (2014-03-13 03:36:56 UTC) #1
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-03-13 03:36:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/198333004/1
6 years, 9 months ago (2014-03-13 03:37:49 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 03:38:13 UTC) #4
commit-bot: I haz the power
Failed to apply patch for android_webview/native/webview_native.gyp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-13 03:38:14 UTC) #5
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-03-13 03:52:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/198333004/20001
6 years, 9 months ago (2014-03-13 03:54:20 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 06:14:30 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=281123
6 years, 9 months ago (2014-03-13 06:14:30 UTC) #9
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-03-13 06:28:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/198333004/20001
6 years, 9 months ago (2014-03-13 06:28:07 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 10:20:40 UTC) #12
Message was sent while issue was closed.
Change committed as 256788

Powered by Google App Engine
This is Rietveld 408576698